Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 42 additions & 0 deletions recipes/buffer-atob-btoa/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# Migrate legacy `buffer.atob()` and `buffer.btoa()` APIs

Migrates usage of the legacy APIs `buffer.atob()` and `buffer.btoa()` to the current recommended approaches.

## Example

### Migrating buffer.atob(data)

**Before:**
```js
const buffer = require('node:buffer');
const data = 'SGVsbG8gV29ybGQh'; // "Hello World!" in base64
const decodedData = buffer.atob(data);
console.log(decodedData); // Outputs: Hello World!
```

**After:**
```js
const data = 'SGVsbG8gV29ybGQh'; // "Hello World!" in base64
const decodedData = Buffer.from(data, 'base64').toString('binary');
console.log(decodedData); // Outputs: Hello World!
```

### Migrating buffer.btoa(data)

**Before:**
```js
const buffer = require('node:buffer');
const data = 'Hello World!';
const encodedData = buffer.btoa(data);
console.log(encodedData); // Outputs: SGVsbG8gV29ybGQh
```

**After:**
```js
const data = 'Hello World!';
const encodedData = Buffer.from(data, 'binary').toString('base64');
console.log(encodedData); // Outputs: SGVsbG8gV29ybGQh
```

## REFS
* [Node.js Documentation: Buffer](https://nodejs.org/api/buffer.html)
21 changes: 21 additions & 0 deletions recipes/buffer-atob-btoa/codemod.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
schema_version: "1.0"
name: "@nodejs/buffer-atob-btoa"
version: "1.0.0"
description: Migrates usage of the legacy APIs `buffer.atob()` and `buffer.btoa()` to the current recommended approaches
author: nekojanai (Jana)
license: MIT
workflow: workflow.yaml
category: migration

targets:
languages:
- javascript
- typescript

keywords:
- transformation
- migration

registry:
access: public
visibility: public
21 changes: 21 additions & 0 deletions recipes/buffer-atob-btoa/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "@nodejs/buffer-atob-btoa",
"version": "1.0.0",
"description": "Migrates usage of the legacy APIs `buffer.atob()` and `buffer.btoa()` to the current recommended approaches",
"type": "module",
"scripts": {
"test": "npx codemod jssg test -l typescript ./src/workflow.ts ./"
},
"repository": {
"type": "git",
"url": "git+https://github.com/nodejs/userland-migrations.git",
"directory": "recipes/buffer-atob-btoa",
"bugs": "https://github.com/nodejs/userland-migrations/issues"
},
"author": "nekojanai (Jana)",
"license": "MIT",
"homepage": "https://github.com/nodejs/userland-migrations/blob/main/recipes/buffer-atob-btoa/README.md",
"dependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe need to add jssg types as devdep to have typing on codemod context

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nekojanai you have to add it for strictness

"@nodejs/codemod-utils": "*"
}
}
79 changes: 79 additions & 0 deletions recipes/buffer-atob-btoa/src/workflow.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
import type { Edit, Kinds, Range, SgNode, SgRoot } from '@codemod.com/jssg-types/main';
import type Js from '@codemod.com/jssg-types/langs/javascript';
import { resolveBindingPath } from '@nodejs/codemod-utils/ast-grep/resolve-binding-path';
import { getNodeRequireCalls } from '@nodejs/codemod-utils/ast-grep/require-call';
import { getNodeImportStatements } from '@nodejs/codemod-utils/ast-grep/import-statement';
import { removeLines } from '@nodejs/codemod-utils/ast-grep/remove-lines';
import { removeBinding } from '@nodejs/codemod-utils/ast-grep/remove-binding';

export default function transform(root: SgRoot<Js>): string | null {
const rootNode = root.root();
const bindingStatementFnTuples: [string, SgNode<Js, Kinds<Js>>, (arg: string) => string][] = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const bindingStatementFnTuples: [string, SgNode<Js, Kinds<Js>>, (arg: string) => string][] = [];
const bindingStatementFnTuples: [string, SgNode<Js>, (arg: string) => string][] = [];

this type can be simplified

const edits: Edit[] = [];
const linesToRemove: Range[] = [];

const updates = [
{
oldBind: "$.atob",
replaceFn: (arg: string) => `Buffer.from(${arg}, 'base64').toString('binary')`
},
{
oldBind: "$.btoa",
replaceFn: (arg: string) => `Buffer.from(${arg}, 'binary').toString('base64')`
}
];

const statements = [...getNodeRequireCalls(root, 'buffer'), ...getNodeImportStatements(root, 'buffer')];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const statements = [...getNodeRequireCalls(root, 'buffer'), ...getNodeImportStatements(root, 'buffer')];
const statements = [
...getNodeRequireCalls(root, 'buffer'),
...getNodeImportStatements(root, 'buffer')
];


for (const statement of statements) {
for (const update of updates) {
const binding = resolveBindingPath(statement, update.oldBind);
if (binding) bindingStatementFnTuples.push([binding, statement, update.replaceFn]);
}
}

for (const [binding, statement, fn] of bindingStatementFnTuples) {

const result = removeBinding(statement, binding);

if (result?.edit) edits.push(result.edit);
if (result?.lineToRemove) linesToRemove.push(result.lineToRemove);

const calls = rootNode.findAll({
rule: {
pattern: `${binding}($ARG)`
}
});

const otherCalls = rootNode.findAll({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you remove that it's should work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But do I not need to check for any other calls to an import before deleting it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh make sense maybe add comment on top of this query

rule: {
all: [
{
pattern: 'buffer.$FN'
},
{
not: {
pattern: '$.btoa($ARG)'
}
},
{
not: {
pattern: '$.atob($ARG)'
}
}
]
}
});

for (const call of calls) {
const argMatch = call.getMatch("ARG");
if (argMatch) edits.push(call.replace(fn(argMatch.text())));
}

if (calls.length === otherCalls.length) {
linesToRemove.push(statement.range());
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!edits.lenght) return null

return removeLines(rootNode.commitEdits(edits), linesToRemove);
}
3 changes: 3 additions & 0 deletions recipes/buffer-atob-btoa/tests/expected/file-00.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
const data = 'SGVsbG8gV29ybGQh'; // "Hello World!" in base64
const decodedData = Buffer.from(data, 'base64').toString('binary');
console.log(decodedData); // Outputs: Hello World!
3 changes: 3 additions & 0 deletions recipes/buffer-atob-btoa/tests/expected/file-01.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
const data = 'Hello World!';
const encodedData = Buffer.from(data, 'binary').toString('base64');
console.log(encodedData); // Outputs: SGVsbG8gV29ybGQh
3 changes: 3 additions & 0 deletions recipes/buffer-atob-btoa/tests/expected/file-02.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
const data = 'Hello World!';
const encodedData = Buffer.from(data, 'binary').toString('base64');
console.log(encodedData); // Outputs: SGVsbG8gV29ybGQh
3 changes: 3 additions & 0 deletions recipes/buffer-atob-btoa/tests/expected/file-03.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
const data = 'Hello World!';
const encodedData = Buffer.from(data, 'binary').toString('base64');
console.log(encodedData); // Outputs: SGVsbG8gV29ybGQh
4 changes: 4 additions & 0 deletions recipes/buffer-atob-btoa/tests/expected/file-04.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import buffer from "node:buffer";
buffer.constants.MAX_LENGTH;
const data = 'Hello World!';
Buffer.from(data, 'binary').toString('base64');
4 changes: 4 additions & 0 deletions recipes/buffer-atob-btoa/tests/expected/file-05.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { isUtf8 } from "node:buffer";
const data = 'Hello World!';
isUtf8(data);
Buffer.from(data, 'base64').toString('binary');
4 changes: 4 additions & 0 deletions recipes/buffer-atob-btoa/tests/input/file-00.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
const buffer = require('node:buffer');
const data = 'SGVsbG8gV29ybGQh'; // "Hello World!" in base64
const decodedData = buffer.atob(data);
console.log(decodedData); // Outputs: Hello World!
4 changes: 4 additions & 0 deletions recipes/buffer-atob-btoa/tests/input/file-01.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
const buffer = require('node:buffer');
const data = 'Hello World!';
const encodedData = buffer.btoa(data);
console.log(encodedData); // Outputs: SGVsbG8gV29ybGQh
4 changes: 4 additions & 0 deletions recipes/buffer-atob-btoa/tests/input/file-02.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import buffer from "node:buffer";
const data = 'Hello World!';
const encodedData = buffer.btoa(data);
console.log(encodedData); // Outputs: SGVsbG8gV29ybGQh
4 changes: 4 additions & 0 deletions recipes/buffer-atob-btoa/tests/input/file-03.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
const buffer = require("node:buffer");
const data = 'Hello World!';
const encodedData = buffer.btoa(data);
console.log(encodedData); // Outputs: SGVsbG8gV29ybGQh
4 changes: 4 additions & 0 deletions recipes/buffer-atob-btoa/tests/input/file-04.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import buffer from "node:buffer";
buffer.constants.MAX_LENGTH;
const data = 'Hello World!';
buffer.btoa(data);
4 changes: 4 additions & 0 deletions recipes/buffer-atob-btoa/tests/input/file-05.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { atob, isUtf8 } from "node:buffer";
const data = 'Hello World!';
isUtf8(data);
atob(data);
27 changes: 27 additions & 0 deletions recipes/buffer-atob-btoa/workflow.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# yaml-language-server: $schema=https://raw.githubusercontent.com/codemod-com/codemod/refs/heads/main/schemas/workflow.json

version: "1"

nodes:
- id: apply-transforms
name: Apply AST Transformations
type: automatic
runtime:
type: direct
steps:
- name: Migrates usage of the legacy APIs `buffer.atob()` and `buffer.btoa()` to the current recommended approaches
js-ast-grep:
js_file: src/workflow.ts
base_path: .
include:
- "**/*.cjs"
- "**/*.js"
- "**/*.jsx"
- "**/*.mjs"
- "**/*.cts"
- "**/*.mts"
- "**/*.ts"
- "**/*.tsx"
exclude:
- "**/node_modules/**"
language: typescript
Loading