Optimize some methods by batching SQL and reducing the number of DB calls#8054
Open
atiq-bs23 wants to merge 5 commits intonopSolutions:developfrom
Open
Optimize some methods by batching SQL and reducing the number of DB calls#8054atiq-bs23 wants to merge 5 commits intonopSolutions:developfrom
atiq-bs23 wants to merge 5 commits intonopSolutions:developfrom
Conversation
…-create-update-product
…-create-update-product
Contributor
Author
atiq-bs23
force-pushed
the
optimizing-sql-for-create-update-product
branch
from
b52c58a to
d9cc66a
Compare
Contributor
|
Hi @atiq-bs23. Thank you for your work, but I can't accept this PR. Numerous markup changes unrelated to the main goal greatly complicate the analysis. It would be better to create separate PRs for each method, or at least for each service. |
Contributor
Author
|
@skoshelev thank you, I'll create PRs separately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes several methods by batching SQL operations and reducing the number of database calls.
The goal is to improve performance and efficiency while keeping the existing behavior unchanged