Optimize some methods by batching SQL and reducing the number of DB calls #8054
+283
−152
Annotations
8 warnings
|
Build:
src/Tests/Nop.Tests/Nop.Services.Tests/Themes/ThemeProviderTests.cs#L13
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build:
src/Libraries/Nop.Services/Connected Services/EuropaCheckVatService/Reference.cs#L328
'checkVatPortTypeClient.CloseAsync()' hides inherited member 'ClientBase<checkVatPortType>.CloseAsync()'. Use the new keyword if hiding was intended.
|
|
Build:
src/Libraries/Nop.Data/Migrations/UpgradeTo470/SchemaMigration.cs#L44
'ProductAttributeValue.PictureId' is obsolete: 'The field is not used since 4.70 and is left only for the update process use the ProductAttributeValuePicture instead'
|
|
Build:
src/Libraries/Nop.Data/Migrations/UpgradeTo470/SchemaMigration.cs#L39
'ProductAttributeCombination.PictureId' is obsolete: 'The field is not used since 4.70 and is left only for the update process use the ProductAttributeCombinationPicture instead'
|
|
Build:
src/Tests/Nop.Tests/Nop.Services.Tests/Themes/ThemeProviderTests.cs#L13
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build:
src/Libraries/Nop.Services/Connected Services/EuropaCheckVatService/Reference.cs#L328
'checkVatPortTypeClient.CloseAsync()' hides inherited member 'ClientBase<checkVatPortType>.CloseAsync()'. Use the new keyword if hiding was intended.
|
|
Build:
src/Libraries/Nop.Data/Migrations/UpgradeTo470/SchemaMigration.cs#L44
'ProductAttributeValue.PictureId' is obsolete: 'The field is not used since 4.70 and is left only for the update process use the ProductAttributeValuePicture instead'
|
|
Build:
src/Libraries/Nop.Data/Migrations/UpgradeTo470/SchemaMigration.cs#L39
'ProductAttributeCombination.PictureId' is obsolete: 'The field is not used since 4.70 and is left only for the update process use the ProductAttributeCombinationPicture instead'
|
Loading