Update timeout example in README.rst #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects the error being thrown in the timeout example and makes it more meaningful by adding sleep to simulate tasks and printing results from processes that finish.
noxdafox
reviewed
Jun 26, 2024
| def function(foo, bar=0): | ||
| time.sleep(foo) # simulate a task | ||
| return foo |
Owner
There was a problem hiding this comment.
bar is not used anymore, the original README was returning foo + bar.
noxdafox
reviewed
Jun 26, 2024
| with ProcessPool(max_workers=5, max_tasks=10) as pool: | ||
| for index in range(0, 10): | ||
| future = pool.schedule(function, [index], {'bar':1}, timeout=TIMEOUT_SECONDS) |
Owner
There was a problem hiding this comment.
Please use KW arguments properly to better indicate how to call this function.
future = pool.schedule(function, args=[index], kwargs={'bar':1}, timeout=TIMEOUT_SECONDS)
noxdafox
requested changes
Jun 26, 2024
Owner
noxdafox
left a comment
noxdafox
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I did not understand what was the issue with the TimeoutError handling.
Could you please make the fixes as requested in the comments?
noxdafox
force-pushed
the
master
branch
6 times, most recently
from
a877e32 to
dcdd92e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the error being thrown in the timeout example in README and makes it more meaningful by adding sleep to simulate tasks and printing results from processes that finish.