lib: bm_zms: misc cleanup #350
Open
+43
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies the explicit error returned by the function. Signed-off-by: Mirko Covizzi <[email protected]>
github-actions
bot
added
the
changelog-entry-required
|
You can find the documentation preview for this PR here. |
MirkoCovizzi
force-pushed
the
fix-zms
branch
from
07772a6 to
611c311
Compare
github-actions
bot
added
the
doc-required
MirkoCovizzi
force-pushed
the
fix-zms
branch
from
611c311 to
0240058
Compare
Adds input parameter checks. Signed-off-by: Mirko Covizzi <[email protected]>
MirkoCovizzi
force-pushed
the
fix-zms
branch
from
0240058 to
13ee4ca
Compare
Adds missing include for `atomic.h`. Signed-off-by: Mirko Covizzi <[email protected]>
MirkoCovizzi
changed the title
Updates the Doxygen to use proper parameter formatting. Signed-off-by: Mirko Covizzi <[email protected]>
eivindj-nordic
approved these changes
Sep 2, 2025
Comment on lines
+120
to
126
| zassert_true(err == -EINVAL, "bm_zms_register unexpected failure"); | ||
|
|
||
| err = bm_zms_register(&fixture->fs, NULL); | ||
| zassert_true(err == -EINVAL, "bm_zms_register unexpected failure"); | ||
|
|
||
| err = bm_zms_register(&fixture->fs, &bm_zms_test_handler); | ||
| zassert_true(err == 0, "bm_zms_register call failure"); |
There was a problem hiding this comment.
This file can probably be cleaned a bit like this. Could be left as a separate PR.
Suggested change
| zassert_true(err == -EINVAL, "bm_zms_register unexpected failure"); | |
| err = bm_zms_register(&fixture->fs, NULL); | |
| zassert_true(err == -EINVAL, "bm_zms_register unexpected failure"); | |
| err = bm_zms_register(&fixture->fs, &bm_zms_test_handler); | |
| zassert_true(err == 0, "bm_zms_register call failure"); | |
| zassert_equal(-EINVAL, err); | |
| err = bm_zms_register(&fixture->fs, NULL); | |
| zassert_equal(-EINVAL, err); | |
| err = bm_zms_register(&fixture->fs, &bm_zms_test_handler); | |
| zassert_ok(err, "bm_zms_register call failure"); |
There was a problem hiding this comment.
Yes, should be separate
Changes `LOG_INF` to `LOG_ERR` where errors are reported. Signed-off-by: Mirko Covizzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the explicit error returned by
the function.
Adds input parameter checks.
Adds missing include for
atomic.h.Updates the Doxygen to use proper parameter formatting.
Changes
LOG_INFtoLOG_ERRwhere errors arereported.