treewide: add support for S145 SoftDevice #408

eivindj-nordic · 2025-10-01T10:17:09Z

Depends on #407
Add support for S145 SoftDevice.
This adds the bm_nrf54l15dk board variants for S145 in addition to updating Kconfig etc. to use the new board variants.

github-actions · 2025-10-01T10:19:29Z

You can find the documentation preview for this PR here.

anhmolt · 2025-10-01T13:20:03Z

boards/nordic/bm_nrf54l15dk/bm_nrf54l15dk_nrf54l05_cpuapp_s145_softdevice.yaml

+ram: 78
+flash: 384


Suggested change

ram: 78

flash: 384

ram: 77

flash: 347

anhmolt · 2025-10-01T13:21:33Z

boards/nordic/bm_nrf54l15dk/bm_nrf54l15dk_nrf54l05_cpuapp_s145_softdevice_mcuboot.yaml

+ram: 78
+flash: 282


Suggested change

ram: 78

flash: 282

ram: 77

flash: 244

anhmolt · 2025-10-01T13:23:16Z

boards/nordic/bm_nrf54l15dk/bm_nrf54l15dk_nrf54l10_cpuapp_s145_softdevice.yaml

+ram: 174
+flash: 896


Suggested change

ram: 174

flash: 896

ram: 173

flash: 859

anhmolt · 2025-10-01T13:25:49Z

boards/nordic/bm_nrf54l15dk/bm_nrf54l15dk_nrf54l10_cpuapp_s145_softdevice_mcuboot.yaml

+ram: 174
+flash: 794


Suggested change

ram: 174

flash: 794

ram: 173

flash: 756

anhmolt · 2025-10-01T13:26:28Z

boards/nordic/bm_nrf54l15dk/bm_nrf54l15dk_nrf54l15_cpuapp_s145_softdevice.yaml

+ram: 238
+flash: 1408


Suggested change

ram: 238

flash: 1408

ram: 237

flash: 1371

anhmolt · 2025-10-01T13:27:00Z

boards/nordic/bm_nrf54l15dk/bm_nrf54l15dk_nrf54l15_cpuapp_s145_softdevice_mcuboot.yaml

+ram: 238
+flash: 1306


Suggested change

ram: 238

flash: 1306

ram: 237

flash: 1268

anhmolt · 2025-10-01T14:23:24Z

boards/nordic/bm_nrf54l15dk/Kconfig.bm_nrf54l15dk

+	select SOC_NRF54L05_CPUAPP if BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S115_SOFTDEVICE || BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S115_SOFTDEVICE_MCUBOOT || BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S145_SOFTDEVICE || BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S145_SOFTDEVICE_MCUBOOT
+	select SOC_NRF54L10_CPUAPP if BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S115_SOFTDEVICE || BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S115_SOFTDEVICE_MCUBOOT || BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S145_SOFTDEVICE || BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S145_SOFTDEVICE_MCUBOOT
+	select SOC_NRF54L15_CPUAPP if BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S115_SOFTDEVICE || BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S115_SOFTDEVICE_MCUBOOT || BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S145_SOFTDEVICE || BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S145_SOFTDEVICE_MCUBOOT


Suggested change

select SOC_NRF54L05_CPUAPP if BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S115_SOFTDEVICE || BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S115_SOFTDEVICE_MCUBOOT || BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S145_SOFTDEVICE || BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S145_SOFTDEVICE_MCUBOOT

select SOC_NRF54L10_CPUAPP if BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S115_SOFTDEVICE || BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S115_SOFTDEVICE_MCUBOOT || BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S145_SOFTDEVICE || BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S145_SOFTDEVICE_MCUBOOT

select SOC_NRF54L15_CPUAPP if BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S115_SOFTDEVICE || BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S115_SOFTDEVICE_MCUBOOT || BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S145_SOFTDEVICE || BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S145_SOFTDEVICE_MCUBOOT

select SOC_NRF54L05_CPUAPP if (BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S115_SOFTDEVICE || \

BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S115_SOFTDEVICE_MCUBOOT || \

BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S145_SOFTDEVICE || \

BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S145_SOFTDEVICE_MCUBOOT)

select SOC_NRF54L10_CPUAPP if (BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S115_SOFTDEVICE || \

BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S115_SOFTDEVICE_MCUBOOT || \

BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S145_SOFTDEVICE || \

BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S145_SOFTDEVICE_MCUBOOT)

select SOC_NRF54L15_CPUAPP if (BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S115_SOFTDEVICE || \

BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S115_SOFTDEVICE_MCUBOOT || \

BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S145_SOFTDEVICE || \

BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S145_SOFTDEVICE_MCUBOOT)

To avoid super long lines.

anhmolt · 2025-10-01T14:58:30Z

boards/nordic/bm_nrf54l15dk/Kconfig.sysbuild

+	default SOFTDEVICE_S115 if BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S115_SOFTDEVICE || \
+				   BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S115_SOFTDEVICE || \
+				   BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S115_SOFTDEVICE || \
+				   BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S115_SOFTDEVICE_MCUBOOT || \
+				   BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S115_SOFTDEVICE_MCUBOOT || \
+				   BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S115_SOFTDEVICE_MCUBOOT
+	default SOFTDEVICE_S145 if BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S145_SOFTDEVICE || \
+				   BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S145_SOFTDEVICE || \
+				   BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S145_SOFTDEVICE || \
+				   BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S145_SOFTDEVICE_MCUBOOT || \
+				   BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S145_SOFTDEVICE_MCUBOOT || \
+				   BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S145_SOFTDEVICE_MCUBOOT


This does not seem right.
There is a difference between having an if around the choice which adds a depends on ..., and using if to conditionally set a default value.

nordicjm · 2025-10-02T10:49:44Z

boards/nordic/bm_nrf54l15dk/bm_nrf54l15dk_nrf54l05_cpuapp_s145_softdevice_defconfig

+# Disable partition manager
+CONFIG_PARTITION_MANAGER_ENABLED=n
+
+# Disable multithreading
+CONFIG_MULTITHREADING=n


lots of things should not be here, this should be taken care of by default image config

That also applies to the S115 variants. Can we take that in a follow-up PR?

nordicjm · 2025-10-02T10:50:13Z

boards/nordic/bm_nrf54l15dk/bm_nrf54l15dk_nrf54l05_cpuapp_s145_softdevice_mcuboot.dts

+
+		boot_partition: partition@0 {
+			label = "boot";
+			reg = <0x00000000 DT_SIZE_K(36)>;


change all MCUboot to 31KiB

That applies to S115 as well so should be done boardwide in a separate commit?

Can we take this as a separate PR for all board variants?

it already is for s115 #357

When do you expect that PR to be ready? Would like to get this in as soon as possible. We should not reduce this here if it is not done for S115 in main while merging.

I've been asking people to review it for weeks...

Ok, I'll leave this as is for now and update if that PR is merged to main before this. If it is the other way around I can create a commit for #357 to align the S145 boards.

nordicjm · 2025-10-02T10:50:30Z

boards/nordic/bm_nrf54l15dk/bm_nrf54l15dk_nrf54l05_cpuapp_s145_softdevice_mcuboot.dts

+			reg = <0x00048000 DT_SIZE_K(64)>;
+		};
+
+		/* 1 kB free space due too slot1_partition partition 2k alignment. */


Add support for S145 SoftDevice. This adds the bm_nrf54l15dk board variants for S145 in addition to updating Kconfig etc. to use the new board variants. Signed-off-by: Eivind Jølsgard <[email protected]>

Add S145 support to selected bluetooth samples. Signed-off-by: Eivind Jølsgard <[email protected]>

eivindj-nordic self-assigned this Oct 1, 2025

eivindj-nordic requested review from a team as code owners October 1, 2025 10:17

github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Oct 1, 2025

eivindj-nordic force-pushed the s145_boards branch 5 times, most recently from c04ea43 to 1cfb9aa Compare October 1, 2025 12:04

anhmolt reviewed Oct 1, 2025

View reviewed changes

eivindj-nordic force-pushed the s145_boards branch from 1cfb9aa to 8606e6b Compare October 2, 2025 08:19

eivindj-nordic removed the request for review from a team October 2, 2025 08:22

nordicjm requested changes Oct 2, 2025

View reviewed changes

eivindj-nordic added 2 commits October 2, 2025 12:58

treewide: add support for S145 SoftDevice

cb69df1

Add support for S145 SoftDevice. This adds the bm_nrf54l15dk board variants for S145 in addition to updating Kconfig etc. to use the new board variants. Signed-off-by: Eivind Jølsgard <[email protected]>

samples: bluetooth: add S145 support to selected samples

c57bec2

Add S145 support to selected bluetooth samples. Signed-off-by: Eivind Jølsgard <[email protected]>

eivindj-nordic force-pushed the s145_boards branch from 8606e6b to c57bec2 Compare October 2, 2025 10:58

eivindj-nordic requested review from nordicjm and anhmolt October 3, 2025 10:33

treewide: add support for S145 SoftDevice #408

Are you sure you want to change the base?

treewide: add support for S145 SoftDevice #408

Uh oh!

Conversation

eivindj-nordic commented Oct 1, 2025

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!