Skip to content

Conversation

@KAGA164
Copy link

@KAGA164 KAGA164 commented Aug 19, 2024

This add support for Clock Control driver for nRF54h20 in radio samples that require manual control of HFXO clock.
Clock Control is in PR and needs go first: nrfconnect/sdk-zephyr#1920

Important

This PR has problems with CI, so it was replaced by the #18694.

@KAGA164 KAGA164 added the DNM label Aug 19, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 19, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 19, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 81259565331f39154c09da0ce621c282a256b25a

more details

sdk-nrf:

PR head: 81259565331f39154c09da0ce621c282a256b25a
merge base: 3ead6a9f71e124a97e89c870a4e02c711f1c879e
target head (main): 25e225e2d0a20ad6fedc3baf902945c2493f4459
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4)
samples
│  ├── bluetooth
│  │  ├── direct_test_mode
│  │  │  ├── src
│  │  │  │  │ dtm.c
│  ├── esb
│  │  ├── esb_prx
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── esb_ptx
│  │  │  ├── src
│  │  │  │  │ main.c
│  ├── peripheral
│  │  ├── radio_test
│  │  │  ├── src
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: 2aae60c2f9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:2aae60c2f9_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
    • sdk-nrf test count: 440
  • ◻️ Integration tests
    • ◻️ test-fw-nrfconnect-ble_samples
    • ◻️ test-fw-nrfconnect-proprietary_esb
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@doki-nordic doki-nordic force-pushed the radio_nrf54h20_clock_control branch from 1d3b6c9 to 8125956 Compare September 11, 2024 15:29
Copy link
Contributor

@maje-emb maje-emb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the nRF54H20 CONFIG_CLOCK_CONTROL_NRF2 is not enabled by default, the sample build fails due to assert: BUILD_ASSERT(false, "No Clock Control driver");

@maje-emb maje-emb self-requested a review September 17, 2024 15:04
@doki-nordic
Copy link
Contributor

On the nRF54H20 CONFIG_CLOCK_CONTROL_NRF2 is not enabled by default, the sample build fails due to assert: BUILD_ASSERT(false, "No Clock Control driver");

@anangl will look at this issue. Probably it should be enabled by default.

@doki-nordic
Copy link
Contributor

doki-nordic commented Oct 16, 2024

Blocked by: nrfconnect/sdk-zephyr#2123

@doki-nordic doki-nordic force-pushed the radio_nrf54h20_clock_control branch from 8125956 to 9040e92 Compare October 16, 2024 14:31
@doki-nordic doki-nordic requested review from a team as code owners October 16, 2024 14:31
@doki-nordic doki-nordic added this to the 2.8.0 milestone Oct 24, 2024
Comment on lines +702 to +705
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NRF_CLOCK_TASK_PLLSTART task triggering applies to nRF54L15.
Since CONFIG_CLOCK_CONTROL_NRF2 is for nRF54HX, it seems that this part is redundant.

@doki-nordic doki-nordic self-assigned this Oct 25, 2024
@doki-nordic doki-nordic added bugfix Fixes a known bug backport v2.8-branch auto-create a PR with same commits to v2.8-branch and removed DNM labels Oct 31, 2024
Kamil Gawor and others added 3 commits November 6, 2024 16:24
This adds support for clock control driver
for nRF54h20 target in the ESB samples.

Jira: NCSDK-28468

Signed-off-by: Kamil Gawor <[email protected]>
Co-authored-by: Dominik Kilian <[email protected]>
This adds clock control driver for nRF54h20
target in Direct Test Mode sample.

Jira: NCSDK-28468

Signed-off-by: Kamil Gawor <[email protected]>
Co-authored-by: Dominik Kilian <[email protected]>
This adds support for clock control driver for
nRF54h20 targets in Radio Test sample.

Jira: NCSDK-28468

Signed-off-by: Kamil Gawor <[email protected]>
@maje-emb maje-emb force-pushed the radio_nrf54h20_clock_control branch from 9040e92 to e5fc6da Compare November 6, 2024 15:26
@doki-nordic
Copy link
Contributor

Important

This PR has problems with CI, so it was replaced by the #18694.

@doki-nordic doki-nordic closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport v2.8-branch auto-create a PR with same commits to v2.8-branch bugfix Fixes a known bug changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants