Skip to content

Radio nrf54h20 clock control #18694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2024
Merged

Radio nrf54h20 clock control #18694

merged 3 commits into from
Nov 8, 2024

Conversation

@doki-nordic
Copy link
Contributor

@doki-nordic doki-nordic commented Nov 7, 2024

This add support for Clock Control driver for nRF54h20 in radio samples that require manual control of HFXO clock.

Important

This is a copy of PR #16909. The old one had problems with CI probably due to the author is no loner in our organization.

@doki-nordic
samples: esb: Clock control for nRF54h20
19946f5 
This adds support for clock control driver
for nRF54h20 target in the ESB samples.

Jira: NCSDK-28468

Signed-off-by: Dominik Kilian <[email protected]>
Co-authored-by: Kamil Gawor <[email protected]>
@doki-nordic doki-nordic added bugfix Fixes a known bug backport v2.8-branch auto-create a PR with same commits to v2.8-branch labels Nov 7, 2024
@doki-nordic doki-nordic added this to the 2.8.0 milestone Nov 7, 2024
@doki-nordic doki-nordic requested a review from a team as a code owner November 7, 2024 08:09
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 7, 2024
@doki-nordic doki-nordic mentioned this pull request Nov 7, 2024
Closed
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 7, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 77e79a60e26982eb1282fdba9276147c0aa3ddc5

more details

sdk-nrf:

PR head: 77e79a60e26982eb1282fdba9276147c0aa3ddc5
merge base: 83b34cdb1402fb05ab9b2ef45dc220bfab4247e8
target head (main): 96557ba34ace48f21c0c27e9d929633ac7ae7f93
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (11) 
samples
│  ├── bluetooth
│  │  ├── direct_test_mode
│  │  │  ├── prj.conf
│  │  │  ├── prj_hci.conf
│  │  │  ├── prj_usb.conf
│  │  │  ├── src
│  │  │  │  │ dtm.c
│  ├── esb
│  │  ├── esb_prx
│  │  │  ├── prj.conf
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── esb_ptx
│  │  │  ├── prj.conf
│  │  │  ├── src
│  │  │  │  │ main.c
│  ├── peripheral
│  │  ├── radio_test
│  │  │  ├── prj.conf
│  │  │  ├── prj_usb.conf
│  │  │  ├── src
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: 6d50eb01ac
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:6d50eb01ac_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 466
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-proprietary_esb
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@doki-nordic
samples: dtm: Add clock control for nRF54h20
d60e820 
This adds clock control driver for nRF54h20
target in Direct Test Mode sample.

Jira: NCSDK-28468

Signed-off-by: Dominik Kilian <[email protected]>
Co-authored-by: Kamil Gawor <[email protected]>
@doki-nordic doki-nordic force-pushed the radio_nrf54h20_clock_control branch from 3af1af4 to cd558a2 Compare November 7, 2024 09:55
@doki-nordic
samples: radio_test: Add clock control for nRF54h20
77e79a6 
This adds support for clock control driver for
nRF54h20 targets in Radio Test sample.

Jira: NCSDK-28468

Signed-off-by: Dominik Kilian <[email protected]>
Co-authored-by: Kamil Gawor <[email protected]>
@doki-nordic doki-nordic force-pushed the radio_nrf54h20_clock_control branch from cd558a2 to 77e79a6 Compare November 7, 2024 09:56
grochu
grochu reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@grochu grochu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, I'd like to clarify a few things.

samples/esb/esb_ptx/src/main.c
}
} while (err == -EAGAIN);

#if defined(NRF54L15_XXAA)
Copy link
Contributor

@grochu grochu Nov 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is repeated from the other branch of the #if directive. How is the selection between CONFIG_CLOCK_CONTROL_NRF and CONFIG_CLOCK_CONTROL_NRF2 determined for nRF54L15? Can it use both clock control implementations, or can we avoid the duplicate?

Copy link
Contributor

@maje-emb maje-emb Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For CONFIG_CLOCK_CONTROL_NRF2 it is not needed.

grochu
grochu reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@grochu grochu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add reference to clock control in the dependencies section of both samples? https://github.com/nrfconnect/sdk-nrf/blob/main/samples/esb/esb_ptx/README.rst#dependencies

@rlubos rlubos merged commit fb9ec88 into nrfconnect:main Nov 8, 2024
12 checks passed
@NordicBuilder NordicBuilder mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maje-emb maje-emb maje-emb approved these changes

@grochu grochu grochu approved these changes

@miha-nordic miha-nordic miha-nordic approved these changes

@rakons rakons Awaiting requested review from rakons

@dchat-nordic dchat-nordic Awaiting requested review from dchat-nordic

Assignees

No one assigned

Labels

backport v2.8-branch auto-create a PR with same commits to v2.8-branch bugfix Fixes a known bug changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

6 participants

@doki-nordic @NordicBuilder @grochu @maje-emb @miha-nordic @rlubos