Skip to content

Conversation

@kapi-no
Copy link
Contributor

@kapi-no kapi-no commented Sep 23, 2024

No description provided.

@kapi-no kapi-no requested a review from a team as a code owner September 23, 2024 09:43
@kapi-no kapi-no requested a review from a team September 23, 2024 09:43
@kapi-no kapi-no requested review from a team as code owners September 23, 2024 09:43
@kapi-no kapi-no requested review from alexsven, andvib, gWacey, koffes and rick1082 and removed request for a team September 23, 2024 09:43
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 23, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 23, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@632ea12 nrfconnect/sdk-connectedhomeip@5a55d60 (master) nrfconnect/[email protected]
sidewalk nrfconnect/sdk-sidewalk@437ef18 nrfconnect/sdk-sidewalk@4d57fc9 (main) nrfconnect/[email protected]
zephyr nrfconnect/sdk-zephyr@ae75e9e nrfconnect/sdk-zephyr@ea7e265 (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 23, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sidewalk: PR head: 4d57fc962da6cf35b97c2fcea05ccac70ab5819a
sdk-nrf: PR head: e5ca83d123a4ef5fbbed8c03de9fcd5bf994647b
matter: PR head: 5a55d6099f6fdbdebdac9c0d7ea41fcfb751e7f2
zephyr: PR head: ea7e265dadf63ab2def0813378f20f2da793877e

more details

sidewalk:

PR head: 4d57fc962da6cf35b97c2fcea05ccac70ab5819a
merge base: 437ef188aa9256e4cf227589ac34217e99ba5bb4
Diff

sdk-nrf:

PR head: e5ca83d123a4ef5fbbed8c03de9fcd5bf994647b
merge base: c1ae40e410ed4effb37374debbacf7052224b4fa
target head (main): fd000ba72ae32e40c42be64ef7f2d7809cba88e2
Diff

matter:

PR head: 5a55d6099f6fdbdebdac9c0d7ea41fcfb751e7f2
merge base: 632ea12cd8fd5a0c867855c863dd1e68d2f07d48
Diff

zephyr:

PR head: ea7e265dadf63ab2def0813378f20f2da793877e
merge base: ae75e9ebc34cafdcd5b68946026f15d030c5c798
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (37)
applications
│  ├── nrf5340_audio
│  │  │ prj_fota.conf
│  ├── nrf_desktop
│  │  ├── configuration
│  │  │  ├── nrf52840dk_nrf52840
│  │  │  │  ├── prj_fast_pair.conf
│  │  │  │  │ prj_mcuboot_smp.conf
│  │  │  ├── nrf52840gmouse_nrf52840
│  │  │  │  ├── prj_fast_pair.conf
│  │  │  │  ├── prj_mcuboot_smp.conf
│  │  │  │  │ prj_release_fast_pair.conf
│  │  │  ├── nrf52kbd_nrf52832
│  │  │  │  │ prj_release_fast_pair.conf
│  │  │  ├── nrf54h20dk_nrf54h20_cpuapp
│  │  │  │  ├── prj.conf
│  │  │  │  │ prj_release.conf
│  │  │  ├── nrf54l15dk_nrf54l15_cpuapp
│  │  │  │  │ prj_fast_pair.conf
│  │  │  ├── nrf54l15pdk_nrf54l15_cpuapp
│  │  │  │  │ prj_fast_pair.conf
modules
│  ├── lib
│  │  ├── matter
│  │  │  ├── config
│  │  │  │  ├── nrfconnect
│  │  │  │  │  ├── chip-module
│  │  │  │  │  │  │ Kconfig.features
│  │  │  │  ├── zephyr
│  │  │  │  │  ├── chip-module
│  │  │  │  │  │  │ Kconfig.features
samples
│  ├── bluetooth
│  │  ├── mesh
│  │  │  ├── common
│  │  │  │  │ smp_bt.c
│  │  │  ├── dfu
│  │  │  │  ├── distributor
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── README.rst
│  │  │  │  │  │ overlay-smp-bt-auth.conf
│  │  ├── peripheral_status
│  │  │  ├── boards
│  │  │  │  ├── thingy53_nrf5340_cpuapp.conf
│  │  │  │  │ thingy53_nrf5340_cpuapp_ns.conf
│  ├── common
│  │  ├── mcumgr_bt_ota_dfu
│  │  │  │ Kconfig
│  ├── nrf5340
│  │  ├── extxip_smp_svr
│  │  │  │ prj.conf
│  ├── suit
│  │  ├── recovery
│  │  │  │ prj.conf
│  │  ├── smp_transfer
│  │  │  ├── sysbuild
│  │  │  │  │ smp_transfer_bt.conf
sidewalk
│  ├── utils
│  │  ├── sidewalk_dfu
│  │  │  │ Kconfig
west.yml
zephyr
│  ├── doc
│  │  ├── releases
│  │  │  │ migration-guide-4.0.rst
│  ├── samples
│  │  ├── subsys
│  │  │  ├── mgmt
│  │  │  │  ├── mcumgr
│  │  │  │  │  ├── smp_svr
│  │  │  │  │  │  │ overlay-bt.conf
│  ├── scripts
│  │  ├── utils
│  │  │  │ migrate_mcumgr_kconfigs.py
│  ├── subsys
│  │  ├── bluetooth
│  │  │  ├── host
│  │  │  │  ├── Kconfig
│  │  │  │  │ Kconfig.gatt
│  │  ├── mgmt
│  │  │  ├── mcumgr
│  │  │  │  ├── grp
│  │  │  │  │  ├── os_mgmt
│  │  │  │  │  │  ├── Kconfig
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ os_mgmt.c
│  │  │  │  ├── transport
│  │  │  │  │  ├── Kconfig.bluetooth
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ smp_bt.c
│  ├── tests
│  │  ├── bluetooth
│  │  │  ├── tester
│  │  │  │  ├── src
│  │  │  │  │  ├── audio
│  │  │  │  │  │  ├── btp_bap_broadcast.c
│  │  │  │  │  │  │ btp_bap_broadcast.h
│  │  ├── subsys
│  │  │  ├── mgmt
│  │  │  │  ├── mcumgr
│  │  │  │  │  ├── all_options
│  │  │  │  │  │  │ prj.conf

Outputs:

Toolchain

Version: 6c44240e03
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:6c44240e03_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 1032
    • sdk-zephyr test count: 6682
  • ❌ Integration tests
    • ✅ test-sdk-audio
    • ✅ desktop52_verification
    • ✅ test-fw-nrfconnect-boot
    • ❌ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_mesh
    • ❌ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-zigbee
    • ✅ test-sdk-find-my
    • ✅ test-sdk-sidewalk
    • ❌ test-sdk-mcuboot
    • ✅ test-sdk-dfu
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@kapi-no kapi-no requested a review from a team as a code owner October 7, 2024 07:28
@kapi-no
Copy link
Contributor Author

kapi-no commented Oct 7, 2024

Rebasing after upmerge completion

Copy link
Contributor

@ludvigsj ludvigsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments on behalf of Mesh

peknis
peknis previously requested changes Oct 7, 2024
Copy link
Contributor

@peknis peknis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but we do not use contractions (like don't)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default, the SMP characteristics don't require authentication when using SMP over Bluetooth to access the :ref:`management subsystem <zephyr:mcu_mgr>`.
By default, the SMP characteristics do not require authentication when using SMP over Bluetooth to access the :ref:`management subsystem <zephyr:mcu_mgr>`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to my change. @peknis, could you raise a PR aligning this part?

It takes a lot of effort to make CI green for such complex upgrades and there is a lot of stuff in the pipeline for the next release. I would like to avoid unnecessary CI runs as part of this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can take this later as this is not a crucial thing.

@totyz totyz requested review from totyz and removed request for andvib October 7, 2024 09:21
Copy link
Contributor

@totyz totyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidewalk tests looks OK - the fails are not connected with this PR

@kapi-no
Copy link
Contributor Author

kapi-no commented Oct 7, 2024

CI rerun to possibly fix FEM and CHIP issues

@kapi-no kapi-no dismissed peknis’s stale review October 7, 2024 11:57

Not directly related to my change

@kapi-no kapi-no added this to the 2.8.0 milestone Oct 7, 2024
@kapi-no
Copy link
Contributor Author

kapi-no commented Oct 7, 2024

FYI, I have a waiver for the only failing downstream job - test_ble_nrf_config (link in our merge comm channel)

Updated the Zephyr manifest to pull in Kconfig changes for the MCUmgr
SMP Bluetooth transport.

Ref: NCSDK-29061

Signed-off-by: Kamil Piszczek <[email protected]>
Updated the CHIP manifest to pull in Kconfig changes for the MCUmgr
SMP Bluetooth transport.

Ref: NCSDK-29061

Signed-off-by: Kamil Piszczek <[email protected]>
Updated the Sidewalk manifest to pull in Kconfig changes for the MCUmgr
SMP Bluetooth transport.

Ref: NCSDK-29061

Signed-off-by: Kamil Piszczek <[email protected]>
Aligned the usage of Kconfig options from the MCUmgr SMP Bluetooth
transport module.

Ref: NCSDK-29061

Signed-off-by: Kamil Piszczek <[email protected]>
@NordicBuilder NordicBuilder removed the DNM label Oct 8, 2024
@kapi-no kapi-no removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 8, 2024
@rlubos rlubos merged commit 6d04523 into nrfconnect:main Oct 8, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.