Skip to content

Conversation

@milewr
Copy link
Contributor

@milewr milewr commented May 7, 2025

Withaout fix, negative temperatures values are wrongly logged on the console. Unification of logging added.

Signed-off-by: Michal Leksinski [email protected]

@milewr milewr requested review from a team as code owners May 7, 2025 22:29
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label May 7, 2025
@github-actions
Copy link

github-actions bot commented May 7, 2025

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-22211/nrf/releases_and_maturity/releases/release-notes-changelog.html

@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 7, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: e02bc615b7cb4d2cf12187d38f676b2e98cc86cb

more details

sdk-nrf:

PR head: e02bc615b7cb4d2cf12187d38f676b2e98cc86cb
merge base: d4642367b6eab3194d025ef9a2e68ff2bafdb90d
target head (v2.9-branch): d4642367b6eab3194d025ef9a2e68ff2bafdb90d
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
applications
│  ├── zigbee_weather_station
│  │  ├── src
│  │  │  │ sensor.c
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 72
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-zigbee
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@peknis peknis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor nit.

@github-actions
Copy link

github-actions bot commented May 8, 2025

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-22211/nrf/releases_and_maturity/releases/release-notes-changelog.html

@mariusz-nordicsemi mariusz-nordicsemi added this to the 2.9.2 milestone May 8, 2025
@github-actions
Copy link

github-actions bot commented May 8, 2025

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-22211/nrf/releases_and_maturity/releases/release-notes-changelog.html

@github-actions
Copy link

github-actions bot commented May 8, 2025

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-22211/nrf/releases_and_maturity/releases/release-notes-changelog.html

@github-actions
Copy link

github-actions bot commented May 8, 2025

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-22211/nrf/releases_and_maturity/releases/release-notes-changelog.html

@github-actions
Copy link

github-actions bot commented May 8, 2025

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-22211/nrf/releases_and_maturity/releases/release-notes-changelog.html

@github-actions
Copy link

github-actions bot commented May 8, 2025

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-22211/nrf/releases_and_maturity/releases/release-notes-changelog.html

@divipillai
Copy link
Contributor

@gmarull - Could you please check the doc build error in the PR. The same error is seen in other doc PRs to the 2.9 branch. For example, #22215.

@divipillai
Copy link
Contributor

@gmarull - Could you please check the doc build error in the PR. The same error is seen in other doc PRs to the 2.9 branch. For example, #22215.

The fix for the doc build issue is now merged. Rebasing the PR will fix the doc build failure.

A fix for logging negative temperature values and logging unification.

Signed-off-by: Michal Leksinski <[email protected]>
@github-actions
Copy link

github-actions bot commented May 8, 2025

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-22211/nrf/releases_and_maturity/releases/release-notes-changelog.html

@rlubos rlubos merged commit fc92a1d into nrfconnect:v2.9-branch May 9, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required PR must not be merged without tech writer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants