-
Notifications
You must be signed in to change notification settings - Fork 1.4k
workflow: Enable Kconfig and sysbuild Kconfig compliance checks #23060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: fa1d3a988edb95f1981480f22da8b613594a6672 more detailssdk-nrf:
Github labels
List of changed files detected by CI (83)
Outputs:ToolchainVersion: a7529a11f4 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds a Kconfig that, when enabled, will hide the Kconfig tree of NCS
This doesn't seem to be what this PR is doing 😛
0625cd6
to
e4d58b8
Compare
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
0e75ac4
to
ae10632
Compare
Fixes capitalisation of comments Signed-off-by: Jamie McCrae <[email protected]>
subsys/app_event_manager/Kconfig
Outdated
|
||
config APP_EVENT_MANAGER_POSTINIT_HOOK | ||
bool "Enable postinit hook" | ||
bool "Postinit hook" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't Post init
more correct ?
bool "Postinit hook" | |
bool "Post init hook" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
subsys/nrf_security/Kconfig.tls
Outdated
|
||
config MBEDTLS_SSL_DTLS_HELLO_VERIFY | ||
bool "Enable support for HellyVerifyRequiest on DTLS servers" | ||
bool "HellyVerifyRequiest on DTLS servers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helly ? Requiest ?
bool "HellyVerifyRequiest on DTLS servers" | |
bool "HelloVerifyRequest on DTLS servers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
This text is completely superfluous and should not have been added Signed-off-by: Jamie McCrae <[email protected]>
Uses a name which is already in the allow list Signed-off-by: Jamie McCrae <[email protected]>
Uses config names that are already in the allow list Signed-off-by: Jamie McCrae <[email protected]>
Fixes an invalid Kconfig name Signed-off-by: Jamie McCrae <[email protected]>
These files should not be added to git, they are generated by compliance check scripts Signed-off-by: Jamie McCrae <[email protected]>
Adds the folders for these locations to the zephyr module file Signed-off-by: Jamie McCrae <[email protected]>
Allows for modules to override the NCS Kconfig root Signed-off-by: Jamie McCrae <[email protected]>
Allows for modules to override the NCS Sysbuild Kconfig root Signed-off-by: Jamie McCrae <[email protected]>
This text is completely superfluous and should not have been added Signed-off-by: Jamie McCrae <[email protected]>
Enables Kconfig and sysbuild Kconfig compliance checks Signed-off-by: Jamie McCrae <[email protected]>
Fixes a Kconfig name Signed-off-by: Jamie McCrae <[email protected]>
Replaces a dummy variable with one in the undef list Signed-off-by: Jamie McCrae <[email protected]>
Fixes some wrong Kconfig usage which missed wildcard characters Signed-off-by: Jamie McCrae <[email protected]>
Adds ZEPHYR_NRF_KCONFIG and SYSBUILD_NRF_KCONFIG variables Signed-off-by: Jamie McCrae <[email protected]>
Removes a Kconfig check that does not exist Signed-off-by: Jamie McCrae <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approved
Also fixes a lot of Kconfig errors