Skip to content

Conversation

nordicjm
Copy link
Contributor

@nordicjm nordicjm commented Jul 1, 2025

Also fixes a lot of Kconfig errors

@nordicjm nordicjm requested a review from a team as a code owner July 1, 2025 08:25
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 1, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 1, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 56

Inputs:

Sources:

sdk-nrf: PR head: fa1d3a988edb95f1981480f22da8b613594a6672

more details

sdk-nrf:

PR head: fa1d3a988edb95f1981480f22da8b613594a6672
merge base: 1a8fae0633f6019203ca1de9e75ad5a95821046d
target head (main): 1a8fae0633f6019203ca1de9e75ad5a95821046d
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (83)
.github
│  ├── workflows
│  │  │ compliance.yml
.gitignore
boards
│  ├── nordic
│  │  ├── nrf52820dongle
│  │  │  │ nrf52820dongle_nrf52820_defconfig
│  │  ├── nrf52833dongle
│  │  │  │ nrf52833dongle_nrf52833_defconfig
│  │  ├── thingy91
│  │  │  │ thingy91_nrf52840_defconfig
│  │  ├── thingy91x
│  │  │  ├── thingy91x_nrf5340_cpuapp_defconfig
│  │  │  ├── thingy91x_nrf5340_cpuapp_ns_defconfig
│  │  │  │ thingy91x_nrf5340_cpunet_defconfig
doc
│  ├── kconfig
│  │  │ conf.py
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── config_and_build
│  │  │  │  ├── sysbuild
│  │  │  │  │  │ sysbuild_images.rst
│  │  ├── security
│  │  │  ├── crypto
│  │  │  │  │ crypto_supported_features.rst
│  │  ├── templates
│  │  │  ├── application_README.rst
│  │  │  │ sample_README.rst
drivers
│  ├── flash
│  │  │ Kconfig
│  ├── mpsl
│  │  ├── flash_sync
│  │  │  │ Kconfig
│  ├── serial
│  │  │ Kconfig.nrf_sw_lpuart
include
│  ├── util
│  │  │ util_macro.h
lib
│  ├── bin
│  │  ├── lwm2m_carrier
│  │  │  │ Kconfig
│  ├── dk_buttons_and_leds
│  │  │ Kconfig
│  ├── edge_impulse
│  │  │ Kconfig
│  ├── fprotect
│  │  │ Kconfig
│  ├── hw_unique_key
│  │  │ Kconfig
│  ├── identity_key
│  │  │ Kconfig
│  ├── lte_link_control
│  │  │ Kconfig
│  ├── modem_attest_token
│  │  │ Kconfig
│  ├── ram_pwrdn
│  │  │ Kconfig
│  ├── wave_gen
│  │  │ Kconfig
modules
│  │ modules.cmake
samples
│  ├── Kconfig
│  ├── nrf5340
│  │  ├── extxip_smp_svr
│  │  │  │ README.rst
scripts
│  ├── partition_manager
│  │  │ partition_manager.rst
│  ├── tests
│  │  │ partition_manager_test.py
subsys
│  ├── app_event_manager
│  │  │ Kconfig
│  ├── audio_module
│  │  │ Kconfig
│  ├── bluetooth
│  │  ├── Kconfig.discovery
│  │  ├── Kconfig.pool
│  │  ├── controller
│  │  │  │ Kconfig
│  │  ├── mesh
│  │  │  ├── Kconfig.dk_prov
│  │  │  │ Kconfig.sensor
│  │  ├── services
│  │  │  ├── cgms
│  │  │  │  │ Kconfig.cgms
│  │  │  ├── fast_pair
│  │  │  │  ├── adv_manager
│  │  │  │  │  │ Kconfig
│  │  │  │  ├── fmdn
│  │  │  │  │  │ Kconfig
│  │  │  │  ├── fp_storage
│  │  │  │  │  │ Kconfig.fp_storage
│  │  │  ├── wifi_prov
│  │  │  │  │ Kconfig.wifi_prov
│  ├── bootloader
│  │  ├── Kconfig
│  │  ├── bl_validation
│  │  │  │ Kconfig
│  ├── caf
│  │  ├── events
│  │  │  ├── Kconfig
│  │  │  ├── Kconfig.factory_reset_event
│  │  │  ├── Kconfig.force_power_down_event
│  │  │  ├── Kconfig.keep_alive_event
│  │  │  ├── Kconfig.module_state_event
│  │  │  │ Kconfig.sensor_event
│  │  ├── modules
│  │  │  ├── Kconfig.ble_adv
│  │  │  ├── Kconfig.ble_bond
│  │  │  ├── Kconfig.ble_state
│  │  │  ├── Kconfig.factory_reset_request
│  │  │  ├── Kconfig.power_manager
│  │  │  │ Kconfig.settings_loader
│  ├── debug
│  │  ├── cpu_load
│  │  │  │ Kconfig
│  │  ├── etb_trace
│  │  │  │ Kconfig
│  │  ├── ppi_trace
│  │  │  │ Kconfig
│  ├── dult
│  │  │ Kconfig
│  ├── mpsl
│  │  ├── clock_ctrl
│  │  │  │ Kconfig
│  ├── net
│  │  ├── lib
│  │  │  ├── download_client
│  │  │  │  │ Kconfig
│  │  │  ├── fota_download
│  │  │  │  │ Kconfig
│  │  │  ├── lwm2m_client_utils
│  │  │  │  │ Kconfig
│  │  │  ├── nrf70_fw_ext
│  │  │  │  │ Kconfig
│  │  │  ├── nrf_cloud
│  │  │  │  ├── Kconfig
│  │  │  │  ├── Kconfig.nrf_cloud_coap
│  │  │  │  ├── Kconfig.nrf_cloud_fota
│  │  │  │  ├── Kconfig.nrf_cloud_location
│  │  │  │  ├── Kconfig.nrf_cloud_mqtt
│  │  │  │  │ Kconfig.nrf_cloud_shadow_info
│  ├── nrf_profiler
│  │  │ Kconfig
│  ├── nrf_security
│  │  ├── Kconfig
│  │  ├── Kconfig.legacy
│  │  ├── Kconfig.psa
│  │  ├── Kconfig.tls
│  │  ├── src
│  │  │  ├── drivers
│  │  │  │  │ Kconfig
│  ├── uart_async_adapter
│  │  │ Kconfig
sysbuild
│  │ Kconfig.wifi
tests
│  ├── crypto
│  │  ├── test_cases
│  │  │  │ test_ecdh.c
zephyr
│  │ module.yml

Outputs:

Toolchain

Version: a7529a11f4
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:a7529a11f4_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ❌ Integration tests
    • ✅ test-sdk-audio
    • ❌ desktop52_verification
    • ✅ test-fw-nrfconnect-apps
    • ✅ test-fw-nrfconnect-ble_mesh
    • ✅ test-fw-nrfconnect-ble_samples
    • ❌ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ❌ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ❌ test-fw-nrfconnect-proprietary_esb
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-fw-nrfconnect-thread-main
    • ✅ test-sdk-find-my
    • ❌ test-fw-nrfconnect-nrf_lrcs_mosh
    • ❌ test-fw-nrfconnect-nrf_lrcs_positioning
    • ❌ test-sdk-wifi
    • ✅ test-low-level
    • ✅ test-sdk-pmic-samples
    • ✅ test-sdk-mcuboot
    • ✅ test-sdk-dfu
    • ✅ test-fw-nrfconnect-ps-main
    • ✅ test-secdom-samples-public
    • ⚠️ test_ble_nrf_config
    • ⚠️ test-fw-nrfconnect-nrf_lrcs_mosh
    • ⚠️ test-fw-nrfconnect-nrf_lrcs_positioning

Note: This message is automatically posted and updated by the CI

@nordicjm nordicjm requested a review from a team July 1, 2025 09:54
@nordicjm nordicjm removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 1, 2025
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 2, 2025
@nordicjm nordicjm removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 2, 2025
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 3, 2025
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a Kconfig that, when enabled, will hide the Kconfig tree of NCS

This doesn't seem to be what this PR is doing 😛

@nordicjm nordicjm force-pushed the hideoptions branch 2 times, most recently from 0625cd6 to e4d58b8 Compare July 4, 2025 10:02
@nordicjm nordicjm requested review from a team as code owners July 4, 2025 10:02
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 4, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added the ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. label Jul 4, 2025
@nordicjm nordicjm force-pushed the hideoptions branch 3 times, most recently from 0e75ac4 to ae10632 Compare July 4, 2025 11:35
@NordicBuilder NordicBuilder removed the DNM label Oct 2, 2025
@nordicjm nordicjm changed the title kconfig: Add hide options Kconfig workflow: Enable Kconfig and sysbuild Kconfig compliance checks Oct 3, 2025
Fixes capitalisation of comments

Signed-off-by: Jamie McCrae <[email protected]>

config APP_EVENT_MANAGER_POSTINIT_HOOK
bool "Enable postinit hook"
bool "Postinit hook"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Post init more correct ?

Suggested change
bool "Postinit hook"
bool "Post init hook"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


config MBEDTLS_SSL_DTLS_HELLO_VERIFY
bool "Enable support for HellyVerifyRequiest on DTLS servers"
bool "HellyVerifyRequiest on DTLS servers"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helly ? Requiest ?

Suggested change
bool "HellyVerifyRequiest on DTLS servers"
bool "HelloVerifyRequest on DTLS servers"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

This text is completely superfluous and should not have been added

Signed-off-by: Jamie McCrae <[email protected]>
Uses a name which is already in the allow list

Signed-off-by: Jamie McCrae <[email protected]>
Uses config names that are already in the allow list

Signed-off-by: Jamie McCrae <[email protected]>
Fixes an invalid Kconfig name

Signed-off-by: Jamie McCrae <[email protected]>
These files should not be added to git, they are generated by
compliance check scripts

Signed-off-by: Jamie McCrae <[email protected]>
Adds the folders for these locations to the zephyr module file

Signed-off-by: Jamie McCrae <[email protected]>
Allows for modules to override the NCS Kconfig root

Signed-off-by: Jamie McCrae <[email protected]>
Allows for modules to override the NCS Sysbuild Kconfig root

Signed-off-by: Jamie McCrae <[email protected]>
This text is completely superfluous and should not have been added

Signed-off-by: Jamie McCrae <[email protected]>
Enables Kconfig and sysbuild Kconfig compliance checks

Signed-off-by: Jamie McCrae <[email protected]>
Fixes a Kconfig name

Signed-off-by: Jamie McCrae <[email protected]>
Replaces a dummy variable with one in the undef list

Signed-off-by: Jamie McCrae <[email protected]>
Fixes some wrong Kconfig usage which missed wildcard characters

Signed-off-by: Jamie McCrae <[email protected]>
Adds ZEPHYR_NRF_KCONFIG and SYSBUILD_NRF_KCONFIG variables

Signed-off-by: Jamie McCrae <[email protected]>
Removes a Kconfig check that does not exist

Signed-off-by: Jamie McCrae <[email protected]>
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved

@rlubos rlubos merged commit b1f505f into nrfconnect:main Oct 3, 2025
17 of 19 checks passed
@nordicjm nordicjm deleted the hideoptions branch October 3, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. doc only doc-required PR must not be merged without tech writer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.