Skip to content

Small improvements customer feedback #24013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2025
Merged

Small improvements customer feedback #24013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
720bdd1
samples: handle failure to connect in RAS samples
olivier-le-sage Aug 15, 2025
34803fc
samples: clarify printout for distance estimates
olivier-le-sage Aug 18, 2025
1289b5c
samples: improve handling for the case where all subevents are aborted
olivier-le-sage Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions samples/bluetooth/channel_sounding_ras_initiator/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,18 @@ static void ranging_data_cb(struct bt_conn *conn, uint16_t ranging_counter, int

LOG_DBG("Ranging data received for ranging counter %d", ranging_counter);

if (latest_local_steps.len == 0) {
LOG_WRN("All subevents in ranging counter %u were aborted",
most_recent_local_ranging_counter);
net_buf_simple_reset(&latest_local_steps);
k_sem_give(&sem_local_steps);

if (!(ras_feature_bits & RAS_FEAT_REALTIME_RD)) {
net_buf_simple_reset(&latest_peer_steps);
}
return;
}

/* This struct is static to avoid putting it on the stack (it's very large) */
static cs_de_report_t cs_de_report;

Expand Down Expand Up @@ -347,13 +359,13 @@ static void connected_cb(struct bt_conn *conn, uint8_t err)
if (err) {
bt_conn_unref(conn);
connection = NULL;
}

connection = bt_conn_ref(conn);
} else {
connection = bt_conn_ref(conn);

k_sem_give(&sem_connected);
k_sem_give(&sem_connected);

dk_set_led_on(CON_STATUS_LED);
dk_set_led_on(CON_STATUS_LED);
}
}

static void disconnected_cb(struct bt_conn *conn, uint8_t reason)
Expand Down Expand Up @@ -710,8 +722,8 @@ int main(void)
for (uint8_t ap = 0; ap < MAX_AP; ap++) {
cs_de_dist_estimates_t distance_on_ap = get_distance(ap);

LOG_INF("Distance estimates on antenna path %u: ifft: %f, "
"phase_slope: %f, rtt: %f",
LOG_INF("Latest distance estimates on antenna path %u: ifft: %f, "
"phase_slope: %f, rtt: %f meters",
ap, (double)distance_on_ap.ifft,
(double)distance_on_ap.phase_slope,
(double)distance_on_ap.rtt);
Expand Down
10 changes: 5 additions & 5 deletions samples/bluetooth/channel_sounding_ras_reflector/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ static void connected_cb(struct bt_conn *conn, uint8_t err)
if (err) {
bt_conn_unref(conn);
connection = NULL;
}

connection = bt_conn_ref(conn);
} else {
connection = bt_conn_ref(conn);

k_sem_give(&sem_connected);
k_sem_give(&sem_connected);

dk_set_led_on(CON_STATUS_LED);
dk_set_led_on(CON_STATUS_LED);
}
}

static void disconnected_cb(struct bt_conn *conn, uint8_t reason)
Expand Down