Skip to content

Small improvements customer feedback #24013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 18, 2025
Merged

Small improvements customer feedback #24013

merged 3 commits into from
Aug 18, 2025

Conversation

olivier-le-sage
Copy link
Contributor

No description provided.

@olivier-le-sage
samples: handle failure to connect in RAS samples
720bdd1 
Handle errors while connecting more gracefully.

Signed-off-by: Olivier Lesage <[email protected]>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 15, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 15, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 1289b5ca6b647d29d82bb190624cc4c21a072e13

more details

sdk-nrf:

PR head: 1289b5ca6b647d29d82bb190624cc4c21a072e13
merge base: 782f5650ed01a87078f37a0265f3d42a84235b75
target head (main): 86ce96e514470192b7016b8157281c399d9d93f8
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2) 
samples
│  ├── bluetooth
│  │  ├── channel_sounding_ras_initiator
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── channel_sounding_ras_reflector
│  │  │  ├── src
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: c5be9c56c7
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:c5be9c56c7_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 12
  • ✅ Integration tests
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@olivier-le-sage olivier-le-sage force-pushed the small-improvements-customer-feedback branch from c78cd9b to dc4197e Compare August 15, 2025 10:51
@olivier-le-sage olivier-le-sage marked this pull request as ready for review August 15, 2025 11:38
@olivier-le-sage olivier-le-sage requested a review from a team as a code owner August 15, 2025 11:38
@ryanjh ryanjh self-requested a review August 18, 2025 07:24
@olivier-le-sage
samples: clarify printout for distance estimates
34803fc 
There was some confusion about what these printouts are.
It's the latest measurements, so event if no new measurements have been
made, the sample will continue printing out the old estimates.

Signed-off-by: Olivier Lesage <[email protected]>
@olivier-le-sage
samples: improve handling for the case where all subevents are aborted
1289b5c 
In case every subevent in the CS procedure was aborted, it would happen
that the sample would try to parse the local steps anyway. An error
message was printed in this case as there were no local steps to parse.

Signed-off-by: Olivier Lesage <[email protected]>
@olivier-le-sage olivier-le-sage force-pushed the small-improvements-customer-feedback branch from dc4197e to 1289b5c Compare August 18, 2025 07:56
@alwa-nordic alwa-nordic requested review from alwa-nordic and removed request for alwa-nordic August 18, 2025 12:28
@rlubos rlubos merged commit 3247bd2 into nrfconnect:main Aug 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alwa-nordic alwa-nordic alwa-nordic left review comments

@ryanjh ryanjh ryanjh approved these changes

@thomas-m-johansen thomas-m-johansen thomas-m-johansen approved these changes

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@olivier-le-sage @NordicBuilder @ryanjh @alwa-nordic @thomas-m-johansen @rlubos