Skip to content

[Backport v3.1-branch] samples: pmic: update npm1300_fuel_gauge sample to support nPM1304 #24079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: ci: Use CI_LIB and test-nrf from v3.1-branch
merged 1 commit into from
Aug 22, 2025
Merged

[Backport v3.1-branch] samples: pmic: update npm1300_fuel_gauge sample to support nPM1304 #24079

merged 1 commit into from
Aug 22, 2025

Conversation

@NordicBuilder
Copy link
Contributor

Backport f1fd516 from #23437.

@seov-nordic @github-actions
samples: pmic: update npm1300_fuel_gauge sample to support nPM1304
b588f27 
Added possibility to choose the nPM1300 or the nPM1304 EK shield to
build for. Adapted code and DTS overlays to accomodate both PMICs.

Signed-off-by: Sergei Ovchinnikov <[email protected]>
(cherry picked from commit f1fd516)
@NordicBuilder NordicBuilder requested review from a team and nordic-auko as code owners August 20, 2025 13:14
@github-actions
Copy link

Since quarantine was modified, please make sure you are following the process described in Quarantine Process.

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Aug 20, 2025
@NordicBuilder
Copy link
Contributor Author

NordicBuilder commented Aug 20, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: b588f2770440e62866245b7df47435c82ff34f07

more details

sdk-nrf:

PR head: b588f2770440e62866245b7df47435c82ff34f07
merge base: e6d9e89100175fa0195b6940c3cf7ca255642b16
target head (v3.1-branch): e6d9e89100175fa0195b6940c3cf7ca255642b16
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (34) 
doc
│  ├── _utils
│  │  │ redirects.py
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── device_guides
│  │  │  │  ├── pmic
│  │  │  │  │  │ npm1300.rst
│  │  ├── links.txt
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  ├── release-notes-2.4.0.rst
│  │  │  │  ├── release-notes-2.6.0.rst
│  │  │  │  ├── release-notes-2.8.0-preview1.rst
│  │  │  │  ├── release-notes-2.8.0.rst
│  │  │  │  ├── release-notes-3.0.0-preview1.rst
│  │  │  │  ├── release-notes-3.0.0-preview2.rst
│  │  │  │  ├── release-notes-3.0.0.rst
│  │  │  │  │ release-notes-3.1.0.rst
samples
│  ├── pmic
│  │  ├── native
│  │  │  ├── npm13xx_fuel_gauge
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── README.rst
│  │  │  │  ├── boards
│  │  │  │  │  ├── extensions
│  │  │  │  │  │  ├── nrf54h20dk
│  │  │  │  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  │  │  │  │  ├── nrf54l15dk
│  │  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │  │  │  │  ├── nrf54lm20dk
│  │  │  │  │  │  │  │ nrf54lm20dk_nrf54lm20a_cpuapp.overlay
│  │  │  │  │  ├── nrf52840dk_nrf52840.overlay
│  │  │  │  │  ├── nrf52dk_nrf52832.overlay
│  │  │  │  │  ├── nrf5340dk_nrf5340_cpuapp.overlay
│  │  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │  │  │  ├── nrf54lm20dk_nrf54lm20a_cpuapp.overlay
│  │  │  │  │  │ nrf9160dk_nrf9160.overlay
│  │  │  │  ├── npm1300.overlay
│  │  │  │  ├── npm1304.overlay
│  │  │  │  ├── prj.conf
│  │  │  │  ├── sample.yaml
│  │  │  │  ├── src
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── battery_model.inc
│  │  │  │  │  ├── battery_model_20mAh.inc
│  │  │  │  │  ├── fuel_gauge.c
│  │  │  │  │  ├── fuel_gauge.h
│  │  │  │  │  │ main.c
scripts
│  │ quarantine_integration.yaml

Outputs:

Toolchain

Version: c5be9c56c7
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:c5be9c56c7_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 19
  • ✅ Integration tests
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-24079/nrf/app_dev/device_guides/pmic/npm1300.html
https://ncsdoc.z6.web.core.windows.net/PR-24079/nrf/releases_and_maturity/releases/release-notes-2.4.0.html
https://ncsdoc.z6.web.core.windows.net/PR-24079/nrf/releases_and_maturity/releases/release-notes-2.6.0.html
https://ncsdoc.z6.web.core.windows.net/PR-24079/nrf/releases_and_maturity/releases/release-notes-2.8.0-preview1.html
https://ncsdoc.z6.web.core.windows.net/PR-24079/nrf/releases_and_maturity/releases/release-notes-2.8.0.html
https://ncsdoc.z6.web.core.windows.net/PR-24079/nrf/releases_and_maturity/releases/release-notes-3.0.0-preview1.html
https://ncsdoc.z6.web.core.windows.net/PR-24079/nrf/releases_and_maturity/releases/release-notes-3.0.0-preview2.html
https://ncsdoc.z6.web.core.windows.net/PR-24079/nrf/releases_and_maturity/releases/release-notes-3.0.0.html
https://ncsdoc.z6.web.core.windows.net/PR-24079/nrf/releases_and_maturity/releases/release-notes-3.1.0.html
https://ncsdoc.z6.web.core.windows.net/PR-24079/nrf/samples/pmic/native/npm13xx_fuel_gauge/README.html

@seov-nordic
Copy link
Contributor

Compliance check failure is a false negative, the failing check URL is actually available. It was the same on the PR to main.

The link (nPM1304) works fine on the documentation preview as well: https://ncsdoc.z6.web.core.windows.net/PR-24079/nrf/samples/pmic/native/npm13xx_fuel_gauge/README.html

@divipillai
Copy link
Contributor

If this change requires a release notes entry, please update this file here : https://github.com/nrfconnect/sdk-nrf/blob/v3.1-branch/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst.

This could be done in the same PR or could create a separate PR to the 3.1 branch.

@seov-nordic
Copy link
Contributor

If this change requires a release notes entry, please update this file here : https://github.com/nrfconnect/sdk-nrf/blob/v3.1-branch/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst.

This could be done in the same PR or could create a separate PR to the 3.1 branch.

This will have to happen in a different PR since I cannot push to this branch. There is another PMIC PR that needs to be merged after this one. I will add changelog entries when both of them are merged :)

@rlubos rlubos merged commit 7a1316f into v3.1-branch Aug 22, 2025
16 of 17 checks passed
@seov-nordic seov-nordic mentioned this pull request Aug 26, 2025
Merged
@karhama karhama deleted the backport-23437-to-v3.1-branch branch October 24, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greg-fer greg-fer greg-fer approved these changes

@peknis peknis peknis approved these changes

@miha-nordic miha-nordic miha-nordic approved these changes

@divipillai divipillai divipillai approved these changes

@nordic-piks nordic-piks nordic-piks approved these changes

@nordic-auko nordic-auko Awaiting requested review from nordic-auko nordic-auko is a code owner

Assignees

No one assigned

Labels

Backport changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@NordicBuilder @seov-nordic @divipillai @greg-fer @peknis @miha-nordic @nordic-piks @rlubos