-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Bluetooth: Mesh: Add external flash support to DFU samples on nRF54L #24880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
DNM until #24879 is merged, since this is required to make this work on the nRF54L15 DK. Can be reviewed already. Note, I have run system tests of DFU upload on both external flash and internal flash across both nRF52840 and nRF54L15, they all pass on my desk. |
9e0e984
to
c0498a8
Compare
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: a1352ee7d4bfcad06659124f2c246b290e0429cf more detailssdk-nrf:
Github labels
List of changed files detected by CI (25)
Outputs:ToolchainVersion: a7529a11f4 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
c0498a8
to
171ae2b
Compare
This adds the required application configuration and mcuboot configuration required to make the DFU samples work with the `ext_flash` file suffix on both nRF52840 and nRF54L15 DKs. Signed-off-by: Ludvig Jordet <[email protected]>
171ae2b
to
a1352ee
Compare
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-24880/nrf/releases_and_maturity/releases/release-notes-changelog.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general lgtm. There are a couple of questions. Please take a look at the comments.
...th/mesh/dfu/distributor/sysbuild/mcuboot/boards/nrf54l15dk_nrf54l15_cpuapp_ext_flash.overlay
Show resolved
Hide resolved
...th/mesh/dfu/distributor/sysbuild/mcuboot/boards/nrf54l15dk_nrf54l15_cpuapp_ext_flash.overlay
Show resolved
Hide resolved
samples/bluetooth/mesh/dfu/distributor/sysbuild/mcuboot/socs/nrf54l10_cpuapp.conf
Show resolved
Hide resolved
samples/bluetooth/mesh/dfu/target/sysbuild/mcuboot/boards/nrf52840dongle_nrf52840.conf
Show resolved
Hide resolved
A general explanation here: A lot of the files under These files are exact copies:
|
This adds the required application configuration and mcuboot configuration required to make the DFU samples work with the
ext_flash
file suffix on both nRF52840 and nRF54L15 DKs.