Skip to content

Conversation

ludvigsj
Copy link
Contributor

@ludvigsj ludvigsj commented Oct 6, 2025

This adds the required application configuration and mcuboot configuration required to make the DFU samples work with the ext_flash file suffix on both nRF52840 and nRF54L15 DKs.

@ludvigsj ludvigsj requested review from a team as code owners October 6, 2025 11:18
@ludvigsj ludvigsj added the DNM label Oct 6, 2025
@NordicBuilder NordicBuilder added doc-required PR must not be merged without tech writer approval. and removed DNM labels Oct 6, 2025
@ludvigsj
Copy link
Contributor Author

ludvigsj commented Oct 6, 2025

DNM until #24879 is merged, since this is required to make this work on the nRF54L15 DK. Can be reviewed already.

Note, I have run system tests of DFU upload on both external flash and internal flash across both nRF52840 and nRF54L15, they all pass on my desk.

@ludvigsj ludvigsj force-pushed the develop/dfu-ext-flash-54 branch from 9e0e984 to c0498a8 Compare October 6, 2025 11:22
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 6, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: a1352ee7d4bfcad06659124f2c246b290e0429cf

more details

sdk-nrf:

PR head: a1352ee7d4bfcad06659124f2c246b290e0429cf
merge base: 5390eed3d2c826cece40a03c993d0712628fed60
target head (main): 492a2e909230366db298db9ca4bc4bc8a13c8bf2
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (25)
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
samples
│  ├── bluetooth
│  │  ├── mesh
│  │  │  ├── dfu
│  │  │  │  ├── distributor
│  │  │  │  │  ├── README.rst
│  │  │  │  │  ├── app_ext_flash.overlay
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ext_flash.conf
│  │  │  │  │  ├── sysbuild
│  │  │  │  │  │  ├── mcuboot.conf
│  │  │  │  │  │  ├── mcuboot
│  │  │  │  │  │  │  ├── app.overlay
│  │  │  │  │  │  │  ├── app_ext_flash.overlay
│  │  │  │  │  │  │  ├── boards
│  │  │  │  │  │  │  │  ├── nrf52840dk_nrf52840_ext_flash.conf
│  │  │  │  │  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp_ext_flash.conf
│  │  │  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ext_flash.overlay
│  │  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  │  ├── socs
│  │  │  │  │  │  │  │  ├── nrf54l10_cpuapp.conf
│  │  │  │  │  │  │  │  │ nrf54l15_cpuapp.conf
│  │  │  │  ├── target
│  │  │  │  │  ├── README.rst
│  │  │  │  │  ├── app_ext_flash.overlay
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ext_flash.conf
│  │  │  │  │  ├── sysbuild
│  │  │  │  │  │  ├── mcuboot
│  │  │  │  │  │  │  ├── app.overlay
│  │  │  │  │  │  │  ├── app_ext_flash.overlay
│  │  │  │  │  │  │  ├── boards
│  │  │  │  │  │  │  │  ├── nrf52840dk_nrf52840_ext_flash.conf
│  │  │  │  │  │  │  │  ├── nrf52840dongle_nrf52840.conf
│  │  │  │  │  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp_ext_flash.conf
│  │  │  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ext_flash.overlay
│  │  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  │  ├── socs
│  │  │  │  │  │  │  │  ├── nrf54l10_cpuapp.conf
│  │  │  │  │  │  │  │  │ nrf54l15_cpuapp.conf

Outputs:

Toolchain

Version: a7529a11f4
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:a7529a11f4_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 12
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-ble_mesh
Disabled integration tests
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@ludvigsj ludvigsj force-pushed the develop/dfu-ext-flash-54 branch from c0498a8 to 171ae2b Compare October 6, 2025 11:26
This adds the required application configuration and mcuboot
configuration required to make the DFU samples work with the `ext_flash`
file suffix on both nRF52840 and nRF54L15 DKs.

Signed-off-by: Ludvig Jordet <[email protected]>
@ludvigsj ludvigsj force-pushed the develop/dfu-ext-flash-54 branch from 171ae2b to a1352ee Compare October 6, 2025 12:03
Copy link
Contributor

@alxelax alxelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general lgtm. There are a couple of questions. Please take a look at the comments.

@ludvigsj
Copy link
Contributor Author

ludvigsj commented Oct 7, 2025

A general explanation here: A lot of the files under sysbuild/mcuboot are exact copies of the files that exist in the sdk-mcuboot repo: https://github.com/nrfconnect/sdk-mcuboot/tree/main/boot/zephyr
Since before this PR, these files were pulled straight from that repo when building, I included them as-is for the most part to keep the configuration the same as it was before this PR.

These files are exact copies:

  • boards/
    • nrf54l15dk_nrf54l15_cpuapp_ext_flash.overlay
    • nrf52840dongle_nrf52840.conf
  • socs/
    • nrf54l10_cpuapp.conf
    • nrf54l15_cpuapp.conf
  • app.overlay
  • prj.conf (except final line in distributor, which is added by us)

@ludvigsj ludvigsj requested a review from alxelax October 7, 2025 08:26
@ludvigsj ludvigsj added the DNM label Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants