[nrf fromlist] GRTC optimizations #10632
compliance.yml
on: pull_request
Run compliance checks on patch series (PR)
3m 5s
Annotations
1 error, 1 warning, and 8 notices
|
Run compliance checks on patch series (PR)
Process completed with exit code 1.
|
|
Run compliance checks on patch series (PR):
ClangFormat.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
-#define MAX_REL_TICKS (MAX_REL_CYCLES / CYC_PER_TICK)
+#define MAX_REL_TICKS (MAX_REL_CYCLES / CYC_PER_TICK)
File:drivers/timer/nrf_grtc_timer.c
Line:55
You may want to run clang-format on this change:
-static uint64_t cc_value; /* Value that is expected to be in CC register. */
+static uint64_t cc_value; /* Value that is expected to be in CC register. */
File:drivers/timer/nrf_grtc_timer.c
Line:72
You may want to run clang-format on this change:
-
File:drivers/timer/nrf_grtc_timer.c
Line:430
You may want to run clang-format on this change:
- nrfx_grtc_channel_callback_set(system_clock_channel_data.channel,
- sys_clock_timeout_handler, NULL);
+ nrfx_grtc_channel_callback_set(system_clock_channel_data.channel, sys_clock_timeout_handler,
+ NULL);
File:drivers/timer/nrf_grtc_timer.c
Line:489
You may want to run clang-format on this change:
-static const char *const ctx_name[] = { "HIGH PRIO ISR", "TIMER CALLBACK", "THREAD" };
+static const char *const ctx_name[] = {"HIGH PRIO ISR", "TIMER CALLBACK", "THREAD"};
File:tests/drivers/timer/nrf_grtc_timer/src/main.c
Line:195
You may want to run clang-format on this change:
- timer->exp_expire = k_ticks_to_cyc_floor32(sys_clock_tick_get_32() + ticks);
+ timer->exp_expire = k_ticks_to_cyc_floor32(sys_clock_tick_get_32() + ticks);
File:tests/drivers/timer/nrf_grtc_timer/src/main.c
Line:225
You may want to run clang-format on this change:
- (test_timer->expire_cnt + 1);
+ (test_timer->expire_cnt + 1);
File:tests/drivers/timer/nrf_grtc_timer/src/main.c
Line:271
You may want to run clang-format on this change:
- zassert_equal(timers[i].state, TIMER_IDLE, "Unexpected timer %d state:%d",
- i, timers[i].state);
- TC_PRINT("Timer%d (%p)\r\n\tstart_cnt:%d abort_cnt:%d expire_cnt:%d\n",
- i, &timers[i], timers[i].start_cnt, timers[i].abort_cnt,
- timers[i].expire_cnt);
+ zassert_equal(timers[i].state, TIMER_IDLE, "Unexpected timer %d state:%d", i,
+ timers[i].state);
+ TC_PRINT("Timer%d (%p)\r\n\tstart_cnt:%d abort_cnt:%d expire_cnt:%d\n", i,
+ &timers[i], timers[i].start_cnt, timers[i].abort_cnt,
+ timers[i].expire_cnt);
TC_PRINT("\tavarage late:%d ticks, max late:%d, min late:%d early:%d\n",
- timers[i].avg_late, timers[i].max_late, timers[i].min_late,
- timers[i].early_cnt);
+ timers[i].avg_late, timers[i].max_late, timers[i].min_late,
+ timers[i].early_cnt);
File:tests/drivers/timer/nrf_grtc_timer/src/main.c
Line:379
|
|
You may want to run clang-format on this change:
tests/drivers/timer/nrf_grtc_timer/src/main.c#L379
tests/drivers/timer/nrf_grtc_timer/src/main.c:379
- zassert_equal(timers[i].state, TIMER_IDLE, "Unexpected timer %d state:%d",
- i, timers[i].state);
- TC_PRINT("Timer%d (%p)\r\n\tstart_cnt:%d abort_cnt:%d expire_cnt:%d\n",
- i, &timers[i], timers[i].start_cnt, timers[i].abort_cnt,
- timers[i].expire_cnt);
+ zassert_equal(timers[i].state, TIMER_IDLE, "Unexpected timer %d state:%d", i,
+ timers[i].state);
+ TC_PRINT("Timer%d (%p)\r\n\tstart_cnt:%d abort_cnt:%d expire_cnt:%d\n", i,
+ &timers[i], timers[i].start_cnt, timers[i].abort_cnt,
+ timers[i].expire_cnt);
TC_PRINT("\tavarage late:%d ticks, max late:%d, min late:%d early:%d\n",
- timers[i].avg_late, timers[i].max_late, timers[i].min_late,
- timers[i].early_cnt);
+ timers[i].avg_late, timers[i].max_late, timers[i].min_late,
+ timers[i].early_cnt);
|
|
You may want to run clang-format on this change:
tests/drivers/timer/nrf_grtc_timer/src/main.c#L271
tests/drivers/timer/nrf_grtc_timer/src/main.c:271
- (test_timer->expire_cnt + 1);
+ (test_timer->expire_cnt + 1);
|
|
You may want to run clang-format on this change:
tests/drivers/timer/nrf_grtc_timer/src/main.c#L225
tests/drivers/timer/nrf_grtc_timer/src/main.c:225
- timer->exp_expire = k_ticks_to_cyc_floor32(sys_clock_tick_get_32() + ticks);
+ timer->exp_expire = k_ticks_to_cyc_floor32(sys_clock_tick_get_32() + ticks);
|
|
You may want to run clang-format on this change:
tests/drivers/timer/nrf_grtc_timer/src/main.c#L195
tests/drivers/timer/nrf_grtc_timer/src/main.c:195
-static const char *const ctx_name[] = { "HIGH PRIO ISR", "TIMER CALLBACK", "THREAD" };
+static const char *const ctx_name[] = {"HIGH PRIO ISR", "TIMER CALLBACK", "THREAD"};
|
|
You may want to run clang-format on this change:
drivers/timer/nrf_grtc_timer.c#L489
drivers/timer/nrf_grtc_timer.c:489
- nrfx_grtc_channel_callback_set(system_clock_channel_data.channel,
- sys_clock_timeout_handler, NULL);
+ nrfx_grtc_channel_callback_set(system_clock_channel_data.channel, sys_clock_timeout_handler,
+ NULL);
|
|
You may want to run clang-format on this change:
drivers/timer/nrf_grtc_timer.c#L430
drivers/timer/nrf_grtc_timer.c:430
-
|
|
You may want to run clang-format on this change:
drivers/timer/nrf_grtc_timer.c#L72
drivers/timer/nrf_grtc_timer.c:72
-static uint64_t cc_value; /* Value that is expected to be in CC register. */
+static uint64_t cc_value; /* Value that is expected to be in CC register. */
|
|
You may want to run clang-format on this change:
drivers/timer/nrf_grtc_timer.c#L55
drivers/timer/nrf_grtc_timer.c:55
-#define MAX_REL_TICKS (MAX_REL_CYCLES / CYC_PER_TICK)
+#define MAX_REL_TICKS (MAX_REL_CYCLES / CYC_PER_TICK)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
compliance.xml
Expired
|
1.26 KB |
sha256:dde8ba3f7b26e42ad276cb89b6694c02d17060c2e388e8664f72f6e711b6e1e5
|
|