[nrf fromlist] GRTC optimizations #2740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
nordic-krch
force-pushed
the
ncs/grtc_optimization
branch
2 times, most recently
from
0d72e4d to
9c533ef
Compare
nordic-krch
force-pushed
the
ncs/grtc_optimization
branch
6 times, most recently
from
813d1ec to
c01b11c
Compare
nordic-krch
force-pushed
the
ncs/grtc_optimization
branch
3 times, most recently
from
0a523b9 to
a9d803b
Compare
nordic-krch
force-pushed
the
ncs/grtc_optimization
branch
6 times, most recently
from
ec5b435 to
3ca0b86
Compare
nordic-krch
force-pushed
the
ncs/grtc_optimization
branch
from
3ca0b86 to
d11f72e
Compare
|
👏👏👏 |
nordic-krch
force-pushed
the
ncs/grtc_optimization
branch
2 times, most recently
from
bca3794 to
1172c56
Compare
nordic-krch
force-pushed
the
ncs/grtc_optimization
branch
3 times, most recently
from
3f659e2 to
4552b8f
Compare
nordic-krch
force-pushed
the
ncs/grtc_optimization
branch
2 times, most recently
from
a104b59 to
094ca6f
Compare
|
nordic-krch
force-pushed
the
ncs/grtc_optimization
branch
from
094ca6f to
331765f
Compare
nordic-segl
approved these changes
Jul 8, 2025
mstasiaknordic
approved these changes
Jul 8, 2025
nika-nordic
approved these changes
Jul 8, 2025
drivers/timer/nrf_grtc_timer.c
Outdated
| } | ||
| #endif /* CONFIG_POWEROFF */ | ||
|
|
||
|
|
There was a problem hiding this comment.
nit: could be redundant
nordic-krch
force-pushed
the
ncs/grtc_optimization
branch
4 times, most recently
from
20870c6 to
b3bbeb5
Compare
… initialization" This reverts commit de4fad1. Signed-off-by: Krzysztof Chruściński <[email protected]>
…ization The GRTC counter is not cleared at startup, therefore the `last_count` variable needs to be initialized accordingly. This change: - Prevents overflow of the `sys_clock_announce()` int32_t parameter - Ensures the correct uptime value, which should be reset during initialization Signed-off-by: Adam Kondraciuk <[email protected]> (cherry picked from commit e77f942)
…ister access Speed up execution of the interrupt handler and sys_clock_set_timeout(). Sys_clock_set_timeout() can be called in two scenarios: from previous timeout expiration handler or freely. If the former case fast path can be used since CC value in the GRTC register just expired and it can be used as a reference for CCADD setting. This is only a single register write so it's much faster. In the latter a longer procedure is applied which also happens in two variants. If value which is set in CC is further in the future (e.g. K_FOREVER was set before) then CC can be safely overwritten with a new value without a risk of triggering unexpected COMPARE event. If value in CC is earlier than the new CC value (if earlier timeout was aborted) then there is a risk of COMPARE event happening while it is being overwritten. That case requires long and safer procedure of setting CC. Update hal_nordic with changes in the nrfx_grtc driver which are needed for nrf_grtc_timer changes. Upstream PR #: 87944 Signed-off-by: Krzysztof Chruściński <[email protected]>
Add stress test that randomly starts and aborts multiple timers from various contexts. Test checks if timers do not expire prematurely. Upstream PR #: 87944 Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
force-pushed
the
ncs/grtc_optimization
branch
from
b3bbeb5 to
409fa87
Compare
nordic-segl
approved these changes
Jul 17, 2025
adamkondraciuk
approved these changes
Jul 17, 2025
kl-cruz
approved these changes
Jul 17, 2025
This was referenced Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in GRTC system clock driver that reduce time spend in GRTC calls by approx. 50%.
PR created to run NCS CI on that change.