Skip to content

Conversation

@MirkoCovizzi
Copy link
Contributor

@MirkoCovizzi MirkoCovizzi commented Jul 16, 2024

This commit removes deprecated RAI socket options.

Deprecated back in version 2.6.0.

manifest-pr-skip

@MirkoCovizzi MirkoCovizzi added this to the ncs-2.8.0 milestone Jul 16, 2024
@MirkoCovizzi MirkoCovizzi self-assigned this Jul 16, 2024
@NordicBuilder NordicBuilder requested review from jukkar and rlubos July 16, 2024 13:25
@MirkoCovizzi MirkoCovizzi changed the title include: net: socket_ncs: remove deprecated RAI [nrf noup] include: net: socket_ncs: remove deprecated RAI Jul 16, 2024
@lemrey
Copy link
Contributor

lemrey commented Jul 16, 2024

I think this should have a !squash [nrf noup] prefix and mention the commit it should be squashed into: d9216e3, right @rlubos ?

@rlubos
Copy link
Contributor

rlubos commented Jul 16, 2024

True, although it's nrf-squash! now:
https://nordicsemi.atlassian.net/wiki/spaces/NCS/pages/108201225/Pull+Requests#PullRequests-ModifyingNCS-specificcommitsfromanOSSrepositoryfork

@MirkoCovizzi
Copy link
Contributor Author

Updated.

@lemrey
Copy link
Contributor

lemrey commented Jul 18, 2024

@MirkoCovizzi I think the nrf squash! line should indicate which commit we should squash this one into:
nrf-squash! [nrf noup] include: net: add NCS extensions

@MirkoCovizzi MirkoCovizzi force-pushed the rm-rai-depr branch 2 times, most recently from 2579e07 to a40fa22 Compare August 6, 2024 11:56
nrf-squash! [nrf noup] include: net: add NCS extensions

This commit removes deprecated RAI socket options.

Signed-off-by: Mirko Covizzi <[email protected]>
@rlubos rlubos merged commit 3b6c6e0 into nrfconnect:main Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants