wifi: Add ext flash support for firmware patches #2062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
requested changes
Oct 7, 2024
krish2718
force-pushed
the
add_ext_flash_support
branch
from
8d2bd3d to
ad27314
Compare
|
Rebased to latest upstream after your review. |
krish2718
force-pushed
the
add_ext_flash_support
branch
from
ad27314 to
54094dc
Compare
rado17
approved these changes
Oct 9, 2024
krish2718
force-pushed
the
add_ext_flash_support
branch
2 times, most recently
from
878a423 to
3c68ba0
Compare
krish2718
force-pushed
the
add_ext_flash_support
branch
2 times, most recently
from
a61ca2b to
88607f7
Compare
nordicjm
requested changes
Oct 14, 2024
krish2718
force-pushed
the
add_ext_flash_support
branch
from
88607f7 to
c113e18
Compare
sachinthegreen
approved these changes
Oct 14, 2024
nordicjm
reviewed
Oct 15, 2024
| - nrf7002dk/nrf5340/cpuapp/nrf7001 | ||
| sample.net.wifi.nrf7002ek: | ||
| extra_args: | ||
| - SB_CONFIG_WIFI_NRF70=y |
There was a problem hiding this comment.
@PerMac can this instead be reworked to use the alt config root?
There was a problem hiding this comment.
Sure, I need to checkout this alt feature, I will take it up in a separate PR, thanks.
nordicjm
approved these changes
Oct 15, 2024
krish2718
force-pushed
the
add_ext_flash_support
branch
from
c113e18 to
e7a9a26
Compare
krish2718
force-pushed
the
add_ext_flash_support
branch
from
e7a9a26 to
692923b
Compare
The Cmake indentation is two spaces. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 3cd4700)
For using external flash the tooling is only available in NCS, so, use the existing Kconfig option to override the FW loading. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit f20e2d6)
This script is needed only when external flash is used to store nRF70 firmware patches. This also uses PM which is supported only in NCS. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit d15b7b5)
This reverts commit b757e7a. Signed-off-by: Chaitanya Tata <[email protected]>
…file Instead of relying on INCBIN macros which do not properly add dependencies, e.g., modifying FW file doesn't trigger rebuild. Use the Zephyr cmake tooling to load the FW patch file as a header. This also improves memory report where the patch target is clearly visible instead of a hidden section. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit b40cb4c)
Make sure Wi-Fi driver is enabled when sysbuild is used. For shields we cannot automate this, as sysbuild doesn't recognize shields, so, Wi-Fi has to be explicitly enabled, this is done for twister. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
add_ext_flash_support
branch
from
692923b to
51dc193
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in prerequisites to add external flash support for nRF70 firmware patches