[nrf romtree] tests/flash_map: Allow custom maps to opt out from some scenarios #2908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
force-pushed
the
pm-flash-map-fixes
branch
from
2d77a99 to
0fcfa82
Compare
nordicjm
reviewed
May 27, 2025
Comment on lines
26
to
29
| /* Partition Manager does not have concept of disabled devices | ||
| * and so does not generate entries for them, into flash map. | ||
| */ | ||
| #if USE_PARTITION_MANAGER == 0 |
There was a problem hiding this comment.
this is very yucky, I really don't think we should be adding noups for things like this
There was a problem hiding this comment.
How do you propose fixing this? Make this part optional in upstream?
There was a problem hiding this comment.
I think I was able to weasel out of this with Kconfigs that automatically get disabled for us due to usage of custom flash map.
de-nordic
force-pushed
the
pm-flash-map-fixes
branch
2 times, most recently
from
4f831a6 to
8209ab1
Compare
de-nordic
changed the title
nordicjm
approved these changes
May 29, 2025
nvlsianpu
approved these changes
May 29, 2025
de-nordic
force-pushed
the
pm-flash-map-fixes
branch
3 times, most recently
from
55153d4 to
d386178
Compare
de-nordic
changed the title
…e scenarios The commit modifies the Flash Map test, providing Kconfigs that allow to opt out from testing disabled partitions and testing DTS node access. Signed-off-by: Dominik Ermel <[email protected]> (cherry picked from commit 53c79c6)
de-nordic
force-pushed
the
pm-flash-map-fixes
branch
from
d386178 to
4c86b6a
Compare
|
|
Already taken from upstream by upmerge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit modifies the Flash Map test, providing Kconfigs that
allow to opt out from testing disabled partitions and testing
DTS node access.
Upstream PR #: 90678