[v3.7.99-ncs2-branch] TWT timeout duration configuration option(build time only) #3195
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Build time configuration option to set TWT setup duration. If AP does not respond to TWT setup request for this period, STA will timeout and report setup failure. It's a v2.9.0 release branch update. Signed-off-by: Ajay Parida <[email protected]>
Pull TWT timeout changes. It's a v2.9.0 release branch manifest update, not intended for upstream. Signed-off-by: Ajay Parida <[email protected]>
ajayparida
force-pushed
the
twt_timeout
branch
from
9303ade to
fe8aba3
Compare
ajayparida
requested review from
krish2718,
sachinthegreen,
udaynordic,
karun2796 and
rajb9
krish2718
reviewed
Aug 12, 2025
| @@ -807,4 +807,15 @@ config NRF70_PASSIVE_SCAN_ONLY | |||
| help | |||
| Enable this configuration to force passive scan on all channels. | |||
| This will override application-specified scan type. | |||
|
|
|||
| config NRF_WIFI_TWT_SETUP_TIMEOUT | |||
There was a problem hiding this comment.
Suggested change
| config NRF_WIFI_TWT_SETUP_TIMEOUT | |
| config NRF_WIFI_TWT_SETUP_TIMEOUT_MS |
krish2718
reviewed
Aug 12, 2025
| The STA will transmit a TWT setup request every 100 milliseconds, | ||
| continuing until this timeout value is reached. If no response is received | ||
| before the timeout expires, the TWT setup is considered failed. | ||
| Note: This is only build time parameter, runtime configuration not supported. |
There was a problem hiding this comment.
Suggested change
| Note: This is only build time parameter, runtime configuration not supported. | |
krish2718
reviewed
Aug 12, 2025
| @@ -807,4 +807,15 @@ config NRF70_PASSIVE_SCAN_ONLY | |||
| help | |||
| Enable this configuration to force passive scan on all channels. | |||
| This will override application-specified scan type. | |||
|
|
|||
| config NRF_WIFI_TWT_SETUP_TIMEOUT | |||
| int "TWT setup request timeout in ms" | |||
There was a problem hiding this comment.
Suggested change
| int "TWT setup request timeout in ms" | |
| int "TWT setup timeout (ms)" |
krish2718
reviewed
Aug 12, 2025
| config NRF_WIFI_TWT_SETUP_TIMEOUT | ||
| int "TWT setup request timeout in ms" | ||
| range 100 10000 | ||
| default 250 |
There was a problem hiding this comment.
why choose 250? If we are trying once every 100ms, this would be rounded off no? 250/100 =2, please make it 300.
There was a problem hiding this comment.
or to keep it simple should we just use TWT_SETUP_RETRY_COUNT (default 3) instead? along with a separate Kconfig TWT_SETUP_TIMEOUT_MS? (default 100ms).
rajb9
approved these changes
Aug 13, 2025
sachinthegreen
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TWT timeout duration configuration option(build time only)