Skip to content

[v3.7.99-ncs2-branch] TWT timeout duration configuration option(build time only) #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v3.7.99-ncs2-branch
Choose a base branch
from
+13 −1
Open

[v3.7.99-ncs2-branch] TWT timeout duration configuration option(build time only) #3195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf6437f
[nrf noup] net: wifi: TWT setup duration
ajayparida Aug 11, 2025
fe8aba3
[nrf noup] manifest: Update revision of nrf_wifi
ajayparida Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions drivers/wifi/nrf_wifi/Kconfig.nrfwifi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,4 +807,15 @@ config NRF70_PASSIVE_SCAN_ONLY
help
Enable this configuration to force passive scan on all channels.
This will override application-specified scan type.

config NRF_WIFI_TWT_SETUP_TIMEOUT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config NRF_WIFI_TWT_SETUP_TIMEOUT
config NRF_WIFI_TWT_SETUP_TIMEOUT_MS

int "TWT setup request timeout in ms"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int "TWT setup request timeout in ms"
int "TWT setup timeout (ms)"

range 100 10000
default 250
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why choose 250? If we are trying once every 100ms, this would be rounded off no? 250/100 =2, please make it 300.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or to keep it simple should we just use TWT_SETUP_RETRY_COUNT (default 3) instead? along with a separate Kconfig TWT_SETUP_TIMEOUT_MS? (default 100ms).

help
Timeout duration (in milliseconds) for the TWT setup procedure.
The STA will transmit a TWT setup request every 100 milliseconds,
continuing until this timeout value is reached. If no response is received
before the timeout expires, the TWT setup is considered failed.
Note: This is only build time parameter, runtime configuration not supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note: This is only build time parameter, runtime configuration not supported.

endif # WIFI_NRF70
1 change: 1 addition & 0 deletions drivers/wifi/nrf_wifi/src/wifi_mgmt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,7 @@ int nrf_wifi_set_twt(const struct device *dev,

twt_info.dialog_token = twt_params->dialog_token;
twt_info.twt_wake_ahead_duration = twt_params->setup.twt_wake_ahead_duration;
twt_info.twt_req_timeout = CONFIG_NRF_WIFI_TWT_SETUP_TIMEOUT;

status = nrf_wifi_fmac_twt_setup(rpu_ctx_zep->rpu_ctx,
vif_ctx_zep->vif_idx,
Expand Down
2 changes: 1 addition & 1 deletion west.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ manifest:
revision: 3cfca0192ff84da919e9bc7978bcc2239cd6a395
path: modules/bsim_hw_models/nrf_hw_models
- name: nrf_wifi
revision: f6b950a3b5c0187fe499b0e518426d5bf88b7e68
revision: pull/67/head
path: modules/lib/nrf_wifi
- name: open-amp
revision: b735edbc739ad59156eb55bb8ce2583d74537719
Expand Down
Loading