Skip to content

Conversation

degjorva
Copy link
Contributor

@degjorva degjorva commented Sep 9, 2025

Add board files for nRF54LM20A/ns.
Update existing nRF54LM20A board files to support this.

Upstream PR #: 95743

@tomi-font
Copy link
Contributor

ERROR: eb4aa991ce733d636f21beb4adb62fa628127ac5: fromlist commit missing an "Upstream PR #:" reference


#ifdef USE_NON_SECURE_ADDRESS_MAP
global_peripherals: peripheral@40000000 {
#address-cells = <1>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are missing reg properties

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe provide the feedback on the upstream PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what you mean/what they are supposed to be. I copied these from l15 any they don't have any reg either.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/zephyrproject-rtos/zephyr/pull/93098/files (which is being blocked for unrelated issues)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!


sram0_s: image_s@20000000 {
/* Secure image memory */
reg = <0x20000000 DT_SIZE_K(256)>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment before says that this should be 208 actually, which one is correct?

*/
slot0_partition: partition@0 {
label = "image-0";
reg = <0x0000000 DT_SIZE_K(512)>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both this number and the ns partition does not match the comment, please update accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already commented on/fixed upstream, better comment on the upstream PR than this which is just a fromlist.

@degjorva degjorva force-pushed the add-support-lm20-ns branch 4 times, most recently from 0fd35ab to 96072bb Compare October 10, 2025 08:45
@degjorva degjorva requested a review from nordicjm October 10, 2025 10:29
@degjorva degjorva force-pushed the add-support-lm20-ns branch 9 times, most recently from 34bda7a to 52d4183 Compare October 15, 2025 12:11
@degjorva
Copy link
Contributor Author

Rebase

@degjorva degjorva force-pushed the add-support-lm20-ns branch from 52d4183 to fa9881b Compare October 17, 2025 09:54
Add board files for nRF54LM20A/ns.
Update existing nRF54LM20A board files to support this.

Upstream PR #: 95743

Signed-off-by: Dag Erik Gjørvad <[email protected]>
(cherry picked from commit 7b908b48875438925d61f21c02442ea06fe2c587)
@degjorva degjorva force-pushed the add-support-lm20-ns branch from fa9881b to 16cddf4 Compare October 17, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants