Skip to content

[nrf fromtree] boards: nordic: Add initial support for nRF54LM20A/ns #3260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

[nrf fromtree] boards: nordic: Add initial support for nRF54LM20A/ns #3260

merged 1 commit into from
Oct 29, 2025

Conversation

@degjorva
Copy link
Contributor

@degjorva degjorva commented Sep 9, 2025 •
edited
Loading

Add board files for nRF54LM20A/ns.
Update existing nRF54LM20A board files to support this.

This was referenced Sep 9, 2025
Closed
Merged
@degjorva degjorva force-pushed the add-support-lm20-ns branch 3 times, most recently from c349175 to eb4aa99 Compare September 15, 2025 08:50
@tomi-font
Copy link
Contributor

tomi-font commented Sep 23, 2025

ERROR: eb4aa991ce733d636f21beb4adb62fa628127ac5: fromlist commit missing an "Upstream PR #:" reference

nordicjm
nordicjm requested changes Sep 24, 2025
View reviewed changes
dts/vendor/nordic/nrf54lm20a.dtsi

#ifdef USE_NON_SECURE_ADDRESS_MAP
global_peripherals: peripheral@40000000 {
#address-cells = <1>;
Copy link
Contributor

@nordicjm nordicjm Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are missing reg properties

Copy link
Contributor

@tomi-font tomi-font Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe provide the feedback on the upstream PR?

Copy link
Contributor Author

@degjorva degjorva Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what you mean/what they are supposed to be. I copied these from l15 any they don't have any reg either.

Copy link
Contributor

@nordicjm nordicjm Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/zephyrproject-rtos/zephyr/pull/93098/files (which is being blocked for unrelated issues)

Copy link
Contributor Author

@degjorva degjorva Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Vge0rge
Vge0rge reviewed Sep 29, 2025
View reviewed changes
boards/nordic/nrf54lm20dk/nrf54lm20dk_nrf54lm20a_cpuapp_ns.dts Outdated

sram0_s: image_s@20000000 {
/* Secure image memory */
reg = <0x20000000 DT_SIZE_K(256)>;
Copy link
Contributor

@Vge0rge Vge0rge Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment before says that this should be 208 actually, which one is correct?

Vge0rge
Vge0rge reviewed Sep 29, 2025
View reviewed changes
dts/vendor/nordic/nrf54lm20a_ns_partition.dtsi
*/
slot0_partition: partition@0 {
label = "image-0";
reg = <0x0000000 DT_SIZE_K(512)>;
Copy link
Contributor

@Vge0rge Vge0rge Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both this number and the ns partition does not match the comment, please update accordingly.

Copy link
Contributor

@tomi-font tomi-font Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already commented on/fixed upstream, better comment on the upstream PR than this which is just a fromlist.

@degjorva degjorva force-pushed the add-support-lm20-ns branch 4 times, most recently from 0fd35ab to 96072bb Compare October 10, 2025 08:45
@degjorva degjorva requested a review from nordicjm October 10, 2025 10:29
@degjorva degjorva force-pushed the add-support-lm20-ns branch 9 times, most recently from 34bda7a to 52d4183 Compare October 15, 2025 12:11
@degjorva
Copy link
Contributor Author

degjorva commented Oct 15, 2025

Rebase

@degjorva degjorva force-pushed the add-support-lm20-ns branch 4 times, most recently from 11d1446 to 51401c0 Compare October 21, 2025 10:09
@degjorva
Copy link
Contributor Author

degjorva commented Oct 21, 2025

Blocked on #3399 so added the relevant commits to this PR to progress

@degjorva degjorva requested review from Vge0rge and tomi-font October 21, 2025 10:10
@degjorva degjorva force-pushed the add-support-lm20-ns branch from 51401c0 to 73cc3ba Compare October 21, 2025 15:07
@degjorva degjorva force-pushed the add-support-lm20-ns branch from 73cc3ba to 57c8331 Compare October 22, 2025 06:38
tomi-font
tomi-font approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now a fromtree

tomi-font
tomi-font requested changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3260 (review)

@degjorva degjorva force-pushed the add-support-lm20-ns branch from 57c8331 to 73cc3ba Compare October 22, 2025 10:20
@degjorva degjorva changed the title [nrf fromlist] boards: nordic: Add initial support for nRF54LM20A/ns [nrf fromtree] boards: nordic: Add initial support for nRF54LM20A/ns Oct 22, 2025
@degjorva degjorva force-pushed the add-support-lm20-ns branch from 73cc3ba to 9060e3e Compare October 23, 2025 16:23
tomi-font
tomi-font approved these changes Oct 24, 2025
View reviewed changes
soc/nordic/nrf54l/Kconfig Outdated
Comment on lines 58 to 61
config SOC_NRF54LX_SKIP_CLOCK_CONFIG
bool
prompt "Skip clock frequency configuration in system initialization" if TRUSTED_EXECUTION_SECURE
default y if TRUSTED_EXECUTION_NONSECURE
Copy link
Contributor

@tomi-font tomi-font Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment in the commit message explaining why the revert could be useful.

@degjorva degjorva force-pushed the add-support-lm20-ns branch from 9060e3e to caf76e0 Compare October 27, 2025 09:24
@degjorva degjorva force-pushed the add-support-lm20-ns branch from caf76e0 to 6123f88 Compare October 28, 2025 11:28
@degjorva
[nrf fromtree] boards: nordic: Add initial support for nRF54LM20A/ns
5fc31b3 
Add board files for nRF54LM20A/ns.
Update existing nRF54LM20A board files to support this.

Signed-off-by: Dag Erik Gjørvad <[email protected]>
(cherry picked from commit de402cb)
@degjorva degjorva force-pushed the add-support-lm20-ns branch from 6123f88 to 5fc31b3 Compare October 29, 2025 08:16
@nordicjm nordicjm merged commit be5d777 into nrfconnect:main Oct 29, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vge0rge Vge0rge Vge0rge approved these changes

@nordicjm nordicjm nordicjm approved these changes

@tomi-font tomi-font tomi-font approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@degjorva @tomi-font @Vge0rge @nordicjm