fix(core): improve buildExplicitTypeScriptDependnecies performance#33963
fix(core): improve buildExplicitTypeScriptDependnecies performance#33963
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit d4dc2d2
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/nx/src/plugins/js/project-graph/build-dependencies/target-project-locator.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/plugins/js/project-graph/build-dependencies/explicit-project-dependencies.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/plugins/js/project-graph/build-dependencies/explicit-project-dependencies.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/plugins/js/project-graph/build-dependencies/explicit-project-dependencies.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/plugins/js/project-graph/build-dependencies/explicit-project-dependencies.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/plugins/js/project-graph/build-dependencies/target-project-locator.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/plugins/js/project-graph/build-dependencies/target-project-locator.ts
Outdated
Show resolved
Hide resolved
| > = {}, | ||
| private readonly npmResolutionCache: NpmResolutionCache = defaultNpmResolutionCache | ||
| private readonly npmResolutionCache: NpmResolutionCache = defaultNpmResolutionCache, | ||
| private readonly packageJsonResolutionCache: PackageJsonResolutionCache = defaultPackageJsonResolutionCache |
There was a problem hiding this comment.
I did not review too carefully.. but just to sanity check me...
This is OK for the daemon because everytime we calculate dependencies, we create a brand new project locator with no cache right? So this cache will not remain between different graph calculations?
There was a problem hiding this comment.
Yes, exactly. The cache is reused only during the single CLI command/daemon OP lifetime.
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
packages/nx/src/plugins/js/project-graph/build-dependencies/target-project-locator.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
Our e2e test failure is caused by an external npm registry issue where @babel/helper-plugin-utils@^7.28.6 is unavailable (only 7.27.1 exists), not by the PR's package.json caching optimizations. This environment_state failure occurs during package installation for react-scripts@5.0.1 and requires either registry recovery or dependency chain updates to resolve.
No code changes were suggested for this issue.
🔂 A CI rerun has been triggered by adding an empty commit to this branch.
🎓 Learn more about Self-Healing CI on nx.dev
packages/nx/src/plugins/js/project-graph/build-dependencies/target-project-locator.ts
Outdated
Show resolved
Hide resolved
…33963) On test repo reduces the `nx/js/dependencies-and-lockfile:createDependencies`: - from `10506ms` - to `3665ms` ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> (cherry picked from commit 95300a2)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
3 participants
On test repo reduces the
nx/js/dependencies-and-lockfile:createDependencies:10506ms3665msCurrent Behavior
Expected Behavior
Related Issue(s)
Fixes #