fix(core): improve buildExplicitTypeScriptDependnecies performance

packages/nx/src/plugins/js/project-graph/build-dependencies/explicit-project-dependencies.ts

@@ -56,34 +56,29 @@ export function buildExplicitTypeScriptDependencies(
     '.mjs',
     '.cjs',
     '.cts',
+    '.vue',
   ];
 
-  // TODO: This can be removed when vue is stable
-  if (isVuePluginInstalled()) {
-    moduleExtensions.push('.vue');
-  }
-
-  for (const [project, fileData] of Object.entries(
-    ctx.filesToProcess.projectFileMap
-  )) {
+  Object.keys(ctx.filesToProcess.projectFileMap).forEach((project) => {
     filesToProcess[project] ??= [];
-    for (const { file } of fileData) {
-      if (moduleExtensions.some((ext) => file.endsWith(ext))) {
-        filesToProcess[project].push(join(workspaceRoot, file));
+    ctx.filesToProcess.projectFileMap[project].forEach((fileData) => {
+      if (moduleExtensions.some((ext) => fileData.file.endsWith(ext))) {
+        filesToProcess[project].push(join(workspaceRoot, fileData.file));
       }
-    }
-  }
+    });
+  });
 
   const { findImports } = require('../../../../native');
-
+  // TODO(jon): check why this function is very slow and whether we it can be optimized
   const imports = findImports(filesToProcess);
 
-  for (const {
-    sourceProject,
-    file,
-    staticImportExpressions,
-    dynamicImportExpressions,
-  } of imports) {
+  for (let i = 0; i < imports.length; i++) {
+    const {
+      sourceProject,
+      file,
+      staticImportExpressions,
+      dynamicImportExpressions,
+    } = imports[i];
     const normalizedFilePath = normalizePath(relative(workspaceRoot, file));
 
     for (const importExpr of staticImportExpressions) {
@@ -131,13 +126,3 @@ export function buildExplicitTypeScriptDependencies(
 
   return res;
 }
-
-function isVuePluginInstalled() {
-  try {
-    // nx-ignore-next-line
-    require.resolve('@nx/vue');
-    return true;
-  } catch {
-    return false;
-  }
-}

packages/nx/src/plugins/js/project-graph/build-dependencies/target-project-locator.ts

@@ -22,13 +22,15 @@ import {
   getRootTsConfigFileName,
   resolveModuleByImport,
 } from '../../utils/typescript';
+import { existsSync } from 'node:fs';
 
 /**
  * The key is a combination of the package name and the workspace relative directory
  * containing the file importing it e.g. `lodash__packages/my-lib`, the value is the
  * resolved external node name from the project graph.
  */
 type NpmResolutionCache = Map<string, string | null>;
+type PackageJsonResolutionCache = Map<string, PackageJson | null>;
 
 type PathPattern = {
   pattern: string;
@@ -44,6 +46,7 @@ type ParsedPatterns = {
  * Use a shared cache to avoid repeated npm package resolution work within the TargetProjectLocator.
  */
 const defaultNpmResolutionCache: NpmResolutionCache = new Map();
+const defaultPackageJsonResolutionCache: PackageJsonResolutionCache = new Map();
 
 const experimentalNodeModules = new Set(['node:sqlite']);
 
@@ -71,7 +74,8 @@ export class TargetProjectLocator {
       string,
       ProjectGraphExternalNode
     > = {},
-    private readonly npmResolutionCache: NpmResolutionCache = defaultNpmResolutionCache
+    private readonly npmResolutionCache: NpmResolutionCache = defaultNpmResolutionCache,
+    private readonly packageJsonResolutionCache: PackageJsonResolutionCache = defaultPackageJsonResolutionCache
   ) {
     /**
      * Only the npm external nodes should be included.
@@ -211,7 +215,8 @@ export class TargetProjectLocator {
       // package.json refers to an external package, we do not match against the version found in there, we instead try and resolve the relevant package how node would
       const externalPackageJson = this.readPackageJson(
         packageName,
-        fullDirPath
+        fullDirPath,
+        workspaceRoot
       );
       // The external package.json path might be not be resolvable, e.g. if a reference has been added to a project package.json, but the install command has not been run yet.
       if (!externalPackageJson) {
@@ -533,18 +538,26 @@ export class TargetProjectLocator {
    */
   private readPackageJson(
     packageName: string,
-    relativeToDir: string
+    relativeToDir: string,
+    workspaceRoot: string
   ): PackageJson | null {
     // The package.json is directly resolvable
     const packageJsonPath = resolveRelativeToDir(
       join(packageName, 'package.json'),
       relativeToDir
     );
     if (packageJsonPath) {
+      if (this.packageJsonResolutionCache.has(packageJsonPath)) {
+        return this.packageJsonResolutionCache.get(packageJsonPath);
+      }
       const parsedPackageJson = readJsonFile(packageJsonPath);
 
       if (parsedPackageJson.name && parsedPackageJson.version) {
+        this.packageJsonResolutionCache.set(packageJsonPath, parsedPackageJson);
         return parsedPackageJson;
+      } else {
+        this.packageJsonResolutionCache.set(packageJsonPath, null);
+        return null;
       }
     }
 
@@ -556,14 +569,29 @@ export class TargetProjectLocator {
 
       while (dir !== dirname(dir)) {
         const packageJsonPath = join(dir, 'package.json');
-        try {
-          const parsedPackageJson = readJsonFile(packageJsonPath);
-          // Ensure the package.json contains the "name" and "version" fields
-          if (parsedPackageJson.name && parsedPackageJson.version) {
-            return parsedPackageJson;
+        if (this.packageJsonResolutionCache.has(packageJsonPath)) {
+          return this.packageJsonResolutionCache.get(packageJsonPath);
+        }
+        if (existsSync(packageJsonPath)) {
+          try {
+            const parsedPackageJson = readJsonFile(packageJsonPath);
+            // Ensure the package.json contains the "name" and "version" fields
+            if (parsedPackageJson.name && parsedPackageJson.version) {
+              this.packageJsonResolutionCache.set(
+                packageJsonPath,
+                parsedPackageJson
+              );
+              return parsedPackageJson;
+            } else {
+              this.packageJsonResolutionCache.set(packageJsonPath, null);
+              return null;
+            }
+          } catch {
+            // Package.json is invalid, keep traversing
           }
-        } catch {
-          // Package.json doesn't exist, keep traversing
+        }
+        if (dir === workspaceRoot) {
+          return null;
         }
         dir = dirname(dir);
       }