Skip to content

Conversation

@fernando-villalba
Copy link
Collaborator

Renames the errBoom sentinel error to errSimulated in both multigrescluster_controller_test.go and tablegroup_controller_test.go.

This clarifies that the error is a sentinel value used specifically for injecting simulated failures during testing, addressing review feedback regarding ambiguous variable naming.

Renames the `errBoom` sentinel error to `errSimulated` in both `multigrescluster_controller_test.go` and `tablegroup_controller_test.go`.

This clarifies that the error is a sentinel value used specifically for injecting simulated failures during testing, addressing review feedback regarding ambiguous variable naming.
@github-actions
Copy link

🔬 Go Test Coverage Report

Summary

Coverage Type Result
Threshold 0%
Previous Test Coverage Unknown%
New Test Coverage 100.0%

Status

✅ PASS

Detail

Show New Coverage
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/multigrescluster_controller.go:43:	Reconcile			100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/multigrescluster_controller.go:99:	handleDelete			100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/multigrescluster_controller.go:115:	checkChildrenDeleted		100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/multigrescluster_controller.go:146:	reconcileGlobalComponents	100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/multigrescluster_controller.go:160:	reconcileGlobalTopoServer	100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/multigrescluster_controller.go:204:	reconcileMultiAdmin		100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/multigrescluster_controller.go:264:	reconcileCells			100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/multigrescluster_controller.go:341:	reconcileDatabases		100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/multigrescluster_controller.go:451:	getGlobalTopoRef		100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/multigrescluster_controller.go:485:	updateStatus			100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/multigrescluster_controller.go:565:	SetupWithManager		100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/template_logic.go:39:			ResolveCoreTemplate		100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/template_logic.go:69:			ResolveCellTemplate		100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/template_logic.go:99:			ResolveShardTemplate		100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/template_logic.go:129:			MergeCellConfig			100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/template_logic.go:160:			MergeShardConfig		100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/template_logic.go:199:			mergeStatelessSpec		100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/template_logic.go:227:			mergeMultiOrchSpec		100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/template_logic.go:237:			mergePoolSpec			100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/template_logic.go:267:			ResolveGlobalTopo		100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/multigrescluster/template_logic.go:287:			ResolveMultiAdmin		100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/tablegroup/tablegroup_controller.go:32:			Reconcile			100.0%
github.com/numtide/multigres-operator/pkg/cluster-handler/controller/tablegroup/tablegroup_controller.go:152:			SetupWithManager		100.0%
total:																(statements)			100.0%

@fernando-villalba fernando-villalba merged commit 3558692 into main Dec 24, 2025
3 checks passed
@fernando-villalba fernando-villalba deleted the simulated-error branch December 24, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants