Skip to content

test: rename errBoom to errSimulated for clarity #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fernando-villalba merged 1 commit into from
Dec 24, 2025
Merged

test: rename errBoom to errSimulated for clarity #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions pkg/cluster-handler/controller/multigrescluster/multigrescluster_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
coreTpl, cellTpl, shardTpl, baseCluster, clusterName, namespace, finalizerName := setupFixtures(
t,
)
errBoom := errors.New("boom")
errSimulated := errors.New("simulated error for testing")

tests := map[string]struct {
multigrescluster *multigresv1alpha1.MultigresCluster
Expand Down Expand Up @@ -716,7 +716,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
"Error: Fetch Cluster Failed": {
existingObjects: []client.Object{},
failureConfig: &testutil.FailureConfig{
OnGet: testutil.FailOnKeyName(clusterName, errBoom),
OnGet: testutil.FailOnKeyName(clusterName, errSimulated),
},
},
"Error: Add Finalizer Failed": {
Expand All @@ -725,7 +725,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
},
existingObjects: []client.Object{},
failureConfig: &testutil.FailureConfig{
OnUpdate: testutil.FailOnObjectName(clusterName, errBoom),
OnUpdate: testutil.FailOnObjectName(clusterName, errSimulated),
},
},
"Error: Remove Finalizer Failed": {
Expand All @@ -736,7 +736,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
},
existingObjects: []client.Object{},
failureConfig: &testutil.FailureConfig{
OnUpdate: testutil.FailOnObjectName(clusterName, errBoom),
OnUpdate: testutil.FailOnObjectName(clusterName, errSimulated),
},
},
"Error: CheckChildrenDeleted (List Cells Failed)": {
Expand All @@ -749,7 +749,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
failureConfig: &testutil.FailureConfig{
OnList: func(list client.ObjectList) error {
if _, ok := list.(*multigresv1alpha1.CellList); ok {
return errBoom
return errSimulated
}
return nil
},
Expand All @@ -765,7 +765,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
failureConfig: &testutil.FailureConfig{
OnList: func(list client.ObjectList) error {
if _, ok := list.(*multigresv1alpha1.TableGroupList); ok {
return errBoom
return errSimulated
}
return nil
},
Expand All @@ -781,7 +781,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
failureConfig: &testutil.FailureConfig{
OnList: func(list client.ObjectList) error {
if _, ok := list.(*multigresv1alpha1.TopoServerList); ok {
return errBoom
return errSimulated
}
return nil
},
Expand All @@ -790,7 +790,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
"Error: Resolve CoreTemplate Failed": {
existingObjects: []client.Object{coreTpl},
failureConfig: &testutil.FailureConfig{
OnGet: testutil.FailOnKeyName("default-core", errBoom),
OnGet: testutil.FailOnKeyName("default-core", errSimulated),
},
},
"Error: Resolve Admin Template Failed (Second Call)": {
Expand All @@ -808,37 +808,37 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
},
},
failureConfig: &testutil.FailureConfig{
OnGet: testutil.FailOnKeyName("admin-core-fail", errBoom),
OnGet: testutil.FailOnKeyName("admin-core-fail", errSimulated),
},
},
"Error: Create GlobalTopo Failed": {
failureConfig: &testutil.FailureConfig{
OnCreate: testutil.FailOnObjectName(clusterName+"-global-topo", errBoom),
OnCreate: testutil.FailOnObjectName(clusterName+"-global-topo", errSimulated),
},
},
"Error: Create MultiAdmin Failed": {
failureConfig: &testutil.FailureConfig{
OnCreate: testutil.FailOnObjectName(clusterName+"-multiadmin", errBoom),
OnCreate: testutil.FailOnObjectName(clusterName+"-multiadmin", errSimulated),
},
},
"Error: Resolve CellTemplate Failed": {
failureConfig: &testutil.FailureConfig{
OnGet: testutil.FailOnKeyName("default-cell", errBoom),
OnGet: testutil.FailOnKeyName("default-cell", errSimulated),
},
},
"Error: List Existing Cells Failed (Reconcile Loop)": {
failureConfig: &testutil.FailureConfig{
OnList: func(list client.ObjectList) error {
if _, ok := list.(*multigresv1alpha1.CellList); ok {
return errBoom
return errSimulated
}
return nil
},
},
},
"Error: Create Cell Failed": {
failureConfig: &testutil.FailureConfig{
OnCreate: testutil.FailOnObjectName(clusterName+"-zone-a", errBoom),
OnCreate: testutil.FailOnObjectName(clusterName+"-zone-a", errSimulated),
},
},
"Error: Prune Cell Failed": {
Expand All @@ -853,27 +853,27 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
},
},
failureConfig: &testutil.FailureConfig{
OnDelete: testutil.FailOnObjectName(clusterName+"-zone-b", errBoom),
OnDelete: testutil.FailOnObjectName(clusterName+"-zone-b", errSimulated),
},
},
"Error: List Existing TableGroups Failed": {
failureConfig: &testutil.FailureConfig{
OnList: func(list client.ObjectList) error {
if _, ok := list.(*multigresv1alpha1.TableGroupList); ok {
return errBoom
return errSimulated
}
return nil
},
},
},
"Error: Resolve ShardTemplate Failed": {
failureConfig: &testutil.FailureConfig{
OnGet: testutil.FailOnKeyName("default-shard", errBoom),
OnGet: testutil.FailOnKeyName("default-shard", errSimulated),
},
},
"Error: Create TableGroup Failed": {
failureConfig: &testutil.FailureConfig{
OnCreate: testutil.FailOnObjectName(clusterName+"-db1-tg1", errBoom),
OnCreate: testutil.FailOnObjectName(clusterName+"-db1-tg1", errSimulated),
},
},
"Error: Prune TableGroup Failed": {
Expand All @@ -888,7 +888,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
},
},
failureConfig: &testutil.FailureConfig{
OnDelete: testutil.FailOnObjectName(clusterName+"-orphan-tg", errBoom),
OnDelete: testutil.FailOnObjectName(clusterName+"-orphan-tg", errSimulated),
},
},
"Error: UpdateStatus (List Cells Failed)": {
Expand All @@ -899,7 +899,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
if _, ok := list.(*multigresv1alpha1.CellList); ok {
count++
if count > 1 {
return errBoom
return errSimulated
}
}
return nil
Expand All @@ -915,7 +915,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
if _, ok := list.(*multigresv1alpha1.TableGroupList); ok {
count++
if count > 1 {
return errBoom
return errSimulated
}
}
return nil
Expand All @@ -925,7 +925,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
},
"Error: Update Status Failed (API Error)": {
failureConfig: &testutil.FailureConfig{
OnStatusUpdate: testutil.FailOnObjectName(clusterName, errBoom),
OnStatusUpdate: testutil.FailOnObjectName(clusterName, errSimulated),
},
},
"Error: Global Topo Resolution Failed (During Cell Reconcile)": {
Expand All @@ -951,7 +951,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
// Call 1: reconcileGlobalComponents -> ResolveCoreTemplate (Succeeds to proceed)
// Call 2: reconcileCells -> getGlobalTopoRef -> ResolveCoreTemplate (Fails)
if count == 2 {
return errBoom
return errSimulated
}
}
return nil
Expand Down Expand Up @@ -983,7 +983,7 @@ func TestMultigresClusterReconciler_Reconcile_Failure(t *testing.T) {
// Call 2: reconcileCells (Succeeds)
// Call 3: reconcileDatabases -> getGlobalTopoRef (Fails)
if count == 3 {
return errBoom
return errSimulated
}
}
return nil
Expand Down
15 changes: 8 additions & 7 deletions pkg/cluster-handler/controller/tablegroup/tablegroup_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ func TestTableGroupReconciler_Reconcile_Failure(t *testing.T) {
_ = multigresv1alpha1.AddToScheme(scheme)

baseTG, tgName, namespace, clusterName, dbName, tgLabelName := setupFixtures(t)
errBoom := errors.New("boom")
errSimulated := errors.New("simulated error for testing")

tests := map[string]struct {
tableGroup *multigresv1alpha1.TableGroup
Expand All @@ -294,7 +294,7 @@ func TestTableGroupReconciler_Reconcile_Failure(t *testing.T) {
tableGroup: baseTG.DeepCopy(),
existingObjects: []client.Object{},
failureConfig: &testutil.FailureConfig{
OnGet: testutil.FailOnKeyName(tgName, errBoom),
OnGet: testutil.FailOnKeyName(tgName, errSimulated),
},
},
"Error: Create/Update Shard Failed": {
Expand All @@ -303,7 +303,7 @@ func TestTableGroupReconciler_Reconcile_Failure(t *testing.T) {
failureConfig: &testutil.FailureConfig{
OnCreate: testutil.FailOnObjectName(
fmt.Sprintf("%s-%s", tgName, "shard-0"),
errBoom,
errSimulated,
),
},
},
Expand All @@ -313,7 +313,7 @@ func TestTableGroupReconciler_Reconcile_Failure(t *testing.T) {
failureConfig: &testutil.FailureConfig{
OnList: func(list client.ObjectList) error {
if _, ok := list.(*multigresv1alpha1.ShardList); ok {
return errBoom
return errSimulated
}
return nil
},
Expand All @@ -323,7 +323,7 @@ func TestTableGroupReconciler_Reconcile_Failure(t *testing.T) {
tableGroup: baseTG.DeepCopy(),
existingObjects: []client.Object{},
failureConfig: &testutil.FailureConfig{
OnList: testutil.FailObjListAfterNCalls(1, errBoom),
OnList: testutil.FailObjListAfterNCalls(1, errSimulated),
},
},
"Error: Delete Orphan Shard Failed": {
Expand All @@ -342,20 +342,21 @@ func TestTableGroupReconciler_Reconcile_Failure(t *testing.T) {
"multigres.com/tablegroup": tgLabelName,
},
},
Spec: multigresv1alpha1.ShardSpec{ShardName: "shard-0"},
},
},
failureConfig: &testutil.FailureConfig{
OnDelete: testutil.FailOnObjectName(
fmt.Sprintf("%s-%s", tgName, "shard-0"),
errBoom,
errSimulated,
),
},
},
"Error: Update Status Failed": {
tableGroup: baseTG.DeepCopy(),
existingObjects: []client.Object{},
failureConfig: &testutil.FailureConfig{
OnStatusUpdate: testutil.FailOnObjectName(tgName, errBoom),
OnStatusUpdate: testutil.FailOnObjectName(tgName, errSimulated),
},
},
}
Expand Down