Skip to content

Conversation

@paulie4
Copy link
Contributor

@paulie4 paulie4 commented Dec 3, 2024

NOTE: I ran the script in a separate commit ffbe438, so anyone who wants to can look at what it output, but I can undo the commit if this PR should only include the change to make_docs.nu and not the changes to the generated files.

@hustcer
Copy link
Contributor

hustcer commented Dec 4, 2024

Thanks for the fix, It looks like nu_plugin_formats and nu_plugin_polars haven't been added while generating the docs?

This reverts commit ffbe438, since I didn't want that as part of the PR and just wanted it so people can see the results of running `make_docs.nu`
@paulie4
Copy link
Contributor Author

paulie4 commented Dec 5, 2024

I used brew install nushell to install Nushell in my Windows WSL Ubuntu, and the formula code nushell.rb in GitHub looks like it first does a cargo install of nushell then does a glob("crates/nu_plugin_*") to cargo install each of those, so I don't know why the two plugins you mentioned would be missing.

Although, as I mentioned in my PR description, I really only included the results of my running of make_docs.nu so people could see what it produces for the files that I was able to generate. Do you guys not have a standard Docker image you use for ensuring consistent results of running make_docs.nu?

To make it clearer, I just pushed another commit that undoes that commit, so this PR will just be the changes to make_docs.nu, and people can look at the ffbe438 commit if they want to see how the changes generated cleaner flags without the confusing , -.

@hustcer
Copy link
Contributor

hustcer commented Dec 6, 2024

Thanks, BTW: you can try the docker images here: https://github.com/nushell/nushell/pkgs/container/nushell

@hustcer hustcer merged commit d079886 into nushell:main Dec 6, 2024
2 checks passed
@hustcer hustcer mentioned this pull request Dec 6, 2024
@paulie4 paulie4 deleted the make_docs-fix-short_flags branch January 13, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants