fix: Misc. fixes to preflight check results #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderboltsid
approved these changes
Jul 7, 2025
dlipovetsky
force-pushed
the
dlipovetsky/preflight-checks-improve-errors
branch
from
6048998 to
014c210
Compare
thunderboltsid
approved these changes
Jul 8, 2025
Merged
dlipovetsky
pushed a commit
that referenced
this pull request
Jul 9, 2025
🤖 I have created a release *beep* *boop* --- ## 0.31.1 (2025-07-08) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Fixes 🔧 * fix(preflight): sanitize kubernetes version for image name preflight check by @thunderboltsid in #1198 * fix: allow http registries by disabling TLS check by @faiq in #1203 * fix: use a better name for registry check by @faiq in #1204 * fix: Misc. fixes to preflight check results by @dlipovetsky in #1202 **Full Changelog**: v0.31.0...v0.31.1 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dlipovetsky
added a commit
that referenced
this pull request
Jul 18, 2025
**What problem does this PR solve?**: Some fields were still not using valid JSONPath. I already fixed the other fields earlier in #1202. **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Fixes some issues with the check results, including:
Also:
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
All changes covered by unit tests.
Special notes for your reviewer: