fix: webhook panic when management cluster has nil topology #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ticket: https://jira.nutanix.com/browse/NCN-110783 - [NKP 2.17.0-dev4] EKS Cluster deploy is erroring out: webhook panic when management cluster has nil topology |
jimmidyson
reviewed
Nov 1, 2025
Member
jimmidyson
left a comment
jimmidyson
left a comment
There was a problem hiding this comment.
Let's add match conditions to the webhook config too to prevent non cc clusters being sent to this webhook at all (keeping the code you've added on this pr as well).
Contributor
Author
Good idea, done in #1375 |
jimmidyson
approved these changes
Nov 3, 2025
manoj-nutanix
approved these changes
Nov 3, 2025
Merged
dkoshkin
added a commit
that referenced
this pull request
Nov 4, 2025
…opology (#1381) **What problem does this PR solve?**: Backport #1372 Fixes a panic in the addon webhook and handles the case when creating a ClusterClass workload cluster in a non ClusterClass management cluster. **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
dkoshkin
added a commit
that referenced
this pull request
Nov 5, 2025
**What problem does this PR solve?**: Recently found a bug #1372 This adds another level of safety and skips unnecessarily calling this webhook for clusters not using topology. **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Fixes a panic in the addon webhook and handles the case when creating a ClusterClass workload cluster in a non ClusterClass management cluster.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: