feat: copy charts to pvc #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supershal
reviewed
Oct 21, 2024
charts/cluster-api-runtime-extensions-nutanix/templates/helm-repository.yaml
Outdated
Show resolved
Hide resolved
supershal
reviewed
Oct 21, 2024
charts/cluster-api-runtime-extensions-nutanix/templates/helm-repository.yaml
Outdated
Show resolved
Hide resolved
supershal
reviewed
Oct 21, 2024
charts/cluster-api-runtime-extensions-nutanix/templates/helm-repository.yaml
Show resolved
Hide resolved
faiq
force-pushed
the
faiq/copy-charts-to-pvc
branch
2 times, most recently
from
c7a02b2 to
518c4b6
Compare
supershal
reviewed
Oct 21, 2024
faiq
force-pushed
the
faiq/copy-charts-to-pvc
branch
2 times, most recently
from
a3ad14c to
f311141
Compare
supershal
reviewed
Oct 21, 2024
charts/cluster-api-runtime-extensions-nutanix/templates/helm-repository.yaml
Outdated
Show resolved
Hide resolved
supershal
reviewed
Oct 21, 2024
charts/cluster-api-runtime-extensions-nutanix/templates/helm-repository.yaml
Show resolved
Hide resolved
faiq
force-pushed
the
faiq/copy-charts-to-pvc
branch
2 times, most recently
from
48da98c to
a4bb0f5
Compare
Contributor
Author
|
looking into the e2e failures |
faiq
force-pushed
the
faiq/copy-charts-to-pvc
branch
from
a4bb0f5 to
f97410c
Compare
faiq
commented
Oct 22, 2024
dkoshkin
reviewed
Oct 22, 2024
charts/cluster-api-runtime-extensions-nutanix/templates/helm-repository.yaml
Outdated
Show resolved
Hide resolved
charts/cluster-api-runtime-extensions-nutanix/templates/helm-repository.yaml
Show resolved
Hide resolved
faiq
commented
Oct 22, 2024
faiq
force-pushed
the
faiq/copy-charts-to-pvc
branch
from
1ea0039 to
7f462bf
Compare
dkoshkin
reviewed
Oct 22, 2024
Contributor
dkoshkin
left a comment
dkoshkin
left a comment
There was a problem hiding this comment.
Looking good, just some minor nits!
charts/cluster-api-runtime-extensions-nutanix/templates/helm-repository.yaml
Outdated
Show resolved
Hide resolved
charts/cluster-api-runtime-extensions-nutanix/templates/helm-repository.yaml
Show resolved
Hide resolved
charts/cluster-api-runtime-extensions-nutanix/templates/helm-repository.yaml
Show resolved
Hide resolved
charts/cluster-api-runtime-extensions-nutanix/templates/helm-repository.yaml
Show resolved
Hide resolved
charts/cluster-api-runtime-extensions-nutanix/templates/helm-repository.yaml
Show resolved
Hide resolved
supershal
approved these changes
Oct 22, 2024
Contributor
supershal
left a comment
supershal
left a comment
There was a problem hiding this comment.
Thank you fixing hard problem.
dkoshkin
reviewed
Oct 23, 2024
faiq
force-pushed
the
faiq/copy-charts-to-pvc
branch
from
fec556e to
c9a05d1
Compare
faiq
force-pushed
the
faiq/copy-charts-to-pvc
branch
from
e425651 to
3550b19
Compare
dkoshkin
approved these changes
Oct 23, 2024
Contributor
dkoshkin
left a comment
dkoshkin
left a comment
There was a problem hiding this comment.
We got there with a real clean solution 🎉
Merged
faiq
added a commit
that referenced
this pull request
Oct 24, 2024
🤖 I have created a release *beep* *boop* --- ## 0.19.0 (2024-10-23) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: copy charts to pvc by @faiq in #947 ### Other Changes * build: pass the Chart version when listing images by @dkoshkin in #945 **Full Changelog**: v0.18.0...v0.19.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Copies charts to a common pvc.
Still missing:
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: