Conversation
- Upgraded @typescript-eslint/eslint-plugin and @typescript-eslint/parser to version 8.0.0. - Updated ESLint to version 9.0.0. - Added a new ESLint configuration file (eslint.config.cjs) with custom rules for TypeScript files.
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughESLint config moved from Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer / Push
participant GH as GitHub Actions
participant Install as Install deps
participant Typecheck as Typecheck (tsc)
participant Lint as Lint (eslint)
participant Build as Build step
participant Publish as Publish/Artifact
Dev->>GH: push commit / PR
GH->>Install: Checkout & Install dependencies
Install-->>GH: deps installed
GH->>Typecheck: npm run typecheck
alt typecheck passes
Typecheck-->>GH: success
GH->>Lint: npm run lint -- --max-warnings=0
alt lint passes
Lint-->>GH: success
GH->>Build: Build the extension
Build-->>GH: build artifacts
GH->>Publish: Publish / continue pipeline
else lint fails
Lint-->>GH: fail (stop)
end
else typecheck fails
Typecheck-->>GH: fail (stop)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the development tooling by upgrading to TypeScript 5.9.3, ESLint 9.x, and @typescript-eslint 8.x, while also adding CI checks for type safety and linting. The changes are entirely development-focused with no runtime or user-facing modifications.
Key Changes:
- Upgraded TypeScript and ESLint to latest major versions with corresponding type definition updates
- Migrated from legacy ESLint configuration to flat config format (eslint.config.cjs)
- Added CI/CD type checking and lint enforcement steps
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated version to 1.5.1, added typecheck script, upgraded dev dependencies to TypeScript 5.9.3, ESLint 9.x, @typescript-eslint 8.x, and pinned @types/vscode |
| eslint.config.cjs | Created new ESLint v9 flat config with TypeScript parser, enhanced naming conventions, and standard rule set |
| CHANGELOG.md | Documented all tooling updates, CI changes, and security fix in version 1.5.1 entry |
| .github/workflows/ci-cd.yml | Added typecheck and lint steps with --max-warnings=0 flag to CI pipeline |
| .eslintrc.js | Removed legacy ESLint configuration file |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
131-131: Consider removing the deprecated--extflag.The
--extflag is deprecated in ESLint 9 in favor of file patterns specified in the config. Sinceeslint.config.cjsalready definesfiles: ['**/*.ts'], you can simplify this to:- "lint": "eslint src --ext ts", + "lint": "eslint src",This change is optional since the flag still works for backwards compatibility.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
.eslintrc.js(0 hunks).github/workflows/ci-cd.yml(1 hunks)CHANGELOG.md(1 hunks)eslint.config.cjs(1 hunks)package.json(2 hunks)
💤 Files with no reviewable changes (1)
- .eslintrc.js
🔇 Additional comments (6)
.github/workflows/ci-cd.yml (1)
33-37: LGTM! CI quality gates added correctly.The new typecheck and lint steps are well-positioned between dependency installation and build, ensuring code quality before packaging. The
--max-warnings=0flag appropriately enforces strict linting standards.CHANGELOG.md (1)
7-24: LGTM! Comprehensive release documentation.The changelog entry clearly documents all tooling updates, CI enhancements, and the security fix, with appropriate notes about the development-only nature of changes.
package.json (3)
5-5: LGTM! Version bump aligns with changelog.The version increment to 1.5.1 correctly reflects the maintenance release.
132-132: LGTM! Typecheck script correctly configured.The typecheck script using
tsc -p ./ --noEmitis the standard approach for type checking without emitting compiled output, perfectly suited for CI validation.
137-144: LGTM! Dependency updates are well-coordinated.The dependency updates are well-executed:
- TypeScript and type definitions upgraded to recent versions
- ESLint 8→9 and @typescript-eslint 6→8 major upgrades align with the new flat config
- @types/vscode changed from
^to~1.70.0intentionally pins to 1.70.x, preventing type mismatches with the minimum supported VS Code version (engines.vscode: ^1.70.0)eslint.config.cjs (1)
1-44: LGTM! ESLint flat config migration executed correctly.The migration from
.eslintrc.jsto ESLint v9 flat config is well-structured:
- CommonJS format (
.cjs) is appropriate for ESLint configuration- The two-config structure correctly separates global ignores from TypeScript-specific rules
- Ignored paths match the previous configuration
- TypeScript parser and plugin setup follows ESLint 9 best practices
- The
@typescript-eslint/naming-conventionrules are comprehensive with progressive specificity:
- Handles constants (UPPER_CASE/camelCase)
- Enforces PascalCase for types/interfaces
- Allows leading underscores for private members
- Provides flexibility for enum members
- Generic rules (
curly,eqeqeq,no-throw-literal,semi) are all appropriately set to'warn'
MatFillion
force-pushed
the
chore/update-dependencies
branch
from
726b478 to
d1032b8
Compare
This pull request updates the development tooling for the extension, focusing on modernizing TypeScript and ESLint configurations, improving CI/CD checks, and resolving a security advisory. There are no runtime or user-facing changes; all updates are for development and maintenance purposes.
Dev tooling and configuration updates:
.eslintrc.jsto the new ESLint v9 flat config ineslint.config.cjs. [1] [2] [3] [4].eslintrc.jsconfig file and replaced it witheslint.config.cjsusing the new flat config format. [1] [2]Continuous Integration improvements:
npm run typecheck) and enforce linting with ESLint, failing on any warnings. [1] [2]Security and maintenance:
tar-fsvianpm audit fix(transitive dependency).Other:
Summary by CodeRabbit
Bug Fixes
Chores