-
Notifications
You must be signed in to change notification settings - Fork 43
fix: nil error on test single function #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just tried this branch out and it fixes the issue! |
|
Hi @michaldziurowski, it fails test |
|
@sergii4 what are the steps for running the test suite? |
Yep, I rushed a bit with removal of
I'm new to lua so maybe there is better way but I'm using plenary test runner via |
|
hey @michaldziurowski I also have a PR which fixes this and related diagnostic errors while parsing test output #49 |
| results[value.id].errors = errors | ||
| end | ||
| if test_result.status == test_statuses.fail then | ||
| if test_result.status == test_statuses.fail and file_id then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't file_id always nil here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should it be? We always have file level test result
|
Hi @michaldziurowski to run test you need: |
|
Hi @michaldziurowski, yeah, it seems pretty logical that attempt index nil value caused by nil. I tested your change, it works for me and tests pass. Thank you for sparing your time on it |
Removed reference from not initialized
file_idvariable tovalue.id.Fixes: #47