Skip to content

fix: nil error on test single function #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergii4 merged 3 commits into from
May 11, 2023
Merged

fix: nil error on test single function #48

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6695a23
fix: nil error on test single function
michaldziurowski May 9, 2023
5b373b0
Revert "fix: nil error on test single function"
michaldziurowski May 10, 2023
3cc0b62
fix: nil error on test single function
michaldziurowski May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lua/neotest-go/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ function adapter.prepare_results(tree, lines, go_root, go_module)
if errors then
results[value.id].errors = errors
end
if test_result.status == test_statuses.fail then
if test_result.status == test_statuses.fail and file_id then
Copy link

@akarl akarl May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't file_id always nil here?

Copy link
Collaborator

@sergii4 sergii4 May 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should it be? We always have file level test result

results[file_id].status = test_statuses.fail
end
end
Expand Down