ioctl: nvme_dsm use nvme_passthru_cmd directly #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Wagner <[email protected]>
The next change will add a static inline implementation of nvme_get_log which uses nvme_get_log_page. Thus move the nvme_get_log_page function up so it can be used directly. Signed-off-by: Daniel Wagner <[email protected]>
Refactor nvme_get_log and nvme_get_log_page to use use struct nvme_passthru_cmd directly and drop the struct nvme_get_log_args. The struct args have are ABI thus it's hard to change it after a release. The nvme_passthru_cmd buffer is a generic buffer and it's possible to use the setters directly on the buffer in an inline function. Besides a reduced API to maintain it also generates better code and avoids one call less when issue a command. Signed-off-by: Daniel Wagner <[email protected]>
Drop struct nvme_format_nvm_args. Signed-off-by: Daniel Wagner <[email protected]>
Drop struct nvme_ns_mgmt_args. Signed-off-by: Daniel Wagner <[email protected]>
Drop struct nvme_ns_attach_args. Signed-off-by: Daniel Wagner <[email protected]>
Drop struct nvme_fw_download_args. Signed-off-by: Daniel Wagner <[email protected]>
Drop struct nvme_fw_commit_args. Signed-off-by: Daniel Wagner <[email protected]>
Drop struct nvme_security_send_args. Signed-off-by: Daniel Wagner <[email protected]>
ikegami-t
force-pushed
the
ioctl-nvme-dsm
branch
from
13b0a90 to
a180203
Compare
Drop struct nvme_dsm_args. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_io_args. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
ioctl-nvme-dsm
branch
from
a180203 to
812ebf2
Compare
To use the fields in nvme_io() and nvme_dsm() functions. Signed-off-by: Tokunori Ikegami <[email protected]>
Drop struct nvme_copy_args. Signed-off-by: Tokunori Ikegami <[email protected]>
igaw
reviewed
Aug 5, 2025
src/nvme/ioctl.h
Outdated
| */ | ||
| int nvme_dsm(nvme_link_t l, struct nvme_dsm_args *args); | ||
| static inline int nvme_dsm(nvme_link_t l, struct nvme_dsm_range *dsm, __u16 nr_ranges, __u32 attrs, | ||
| __u32 nsid, __u32 *result) |
There was a problem hiding this comment.
As I just figured out, the nsid is in cdw0, so it should be right after nvme_link_t l. Sorry for my mistake.
|
Looks great! If you could reorder the |
Also order the pointer and its length member go to the end of the list. Signed-off-by: Tokunori Ikegami <[email protected]>
Author
|
Just fixed the review comments. Thank you. |
igaw
force-pushed
the
libnvme2
branch
2 times, most recently
from
58a0811 to
5fa5c8a
Compare
|
I'll pick those and rebase them on the libnvme2 branch. Let me figure out what is the simplest way. |
|
I've picked these directly. They uncovered a bunch of bugs in the handling of the |
|
Applied. I'll merge the nsid match into the other changes later. Thanks! |
igaw
reviewed
Aug 8, 2025
| NVME_VAL(NVM_CDW12_STC) | | ||
| NVME_VAL(NVM_CDW12_PRINFO) | | ||
| NVME_VAL(NVM_CDW12_FUA) | | ||
| NVME_VAL(NVM_CDW12_LR), |
There was a problem hiding this comment.
btw, this masks is already shifted thus it doesn't work as expected. I've added the necessary >> NVME_NVM_CDW12_CONTROL_SHIFT so it works. Caught by meson test -C .build :)
Author
|
Thank you. Noted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop struct nvme_dsm_args.