ioctl: nvme_set_features use nvme_passthru_cmd directly #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaisenbacherD
force-pushed
the
libnvme2-dennis-wip
branch
from
04cdc89 to
24f3e29
Compare
igaw
reviewed
Aug 3, 2025
MaisenbacherD
force-pushed
the
libnvme2-dennis-wip
branch
from
24f3e29 to
58e5308
Compare
igaw
reviewed
Aug 5, 2025
igaw
reviewed
Aug 5, 2025
MaisenbacherD
force-pushed
the
libnvme2-dennis-wip
branch
from
0ecb91b to
987a088
Compare
Author
|
I am working on reordering the arguments now and then providing a nvme-cli patch for those changes. |
MaisenbacherD
force-pushed
the
libnvme2-dennis-wip
branch
from
987a088 to
b0cbebc
Compare
Author
|
Reordering of arguments is done. I have some more indentation cleanup to do. |
MaisenbacherD
force-pushed
the
libnvme2-dennis-wip
branch
2 times, most recently
from
72c232d to
5b41a70
Compare
Drop struct nvme_set_features_args. Signed-off-by: Dennis Maisenbacher <[email protected]>
Introduce a timeout variable to nvme_link that can be adjusted by the user. If the timeout value of the command to be submitted matches the default value, it is overwritten with the nvme_link specific timeout. Signed-off-by: Dennis Maisenbacher <[email protected]>
MaisenbacherD
force-pushed
the
libnvme2-dennis-wip
branch
from
5b41a70 to
6f7b6a6
Compare
Author
|
@igaw Do you already have some patches lying around for nvme-cli3 that compiles with current nvme-experiments/libnvme2? Otherwise, I will rebase to where nvme_passthu_cmd was not used directly yet. :) |
|
nvme-cli3 is in sync up to the ioctl.h changes. so after that it wont compile |
|
I'll pull this PR and do some reorder of the patches in the branch as rebase etc. |
|
Thanks btw! |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop struct nvme_set_features_args.