Skip to content

ioctl: nvme_set_features use nvme_passthru_cmd directly #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 2 commits into from
Aug 8, 2025
Merged

ioctl: nvme_set_features use nvme_passthru_cmd directly #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f694ab2
ioctl: nvme_set_features use nvme_passthru_cmd directly
MaisenbacherD Jul 30, 2025
6f7b6a6
ioctl: drop timeout arguments
MaisenbacherD Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions src/nvme/api-types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,38 +86,6 @@ struct nvme_get_log_args {
bool ot;
};

/**
* struct nvme_set_features_args - Arguments for the NVMe Admin Set Feature command
* @result: The command completion result from CQE dword0
* @data: User address of feature data, if applicable
* @args_size: Size of &struct nvme_set_features_args
* @timeout: Timeout in ms
* @nsid: Namespace ID, if applicable
* @cdw11: Value to set the feature to
* @cdw12: Feature specific command dword12 field
* @cdw13: Feature specific command dword13 field
* @cdw15: Feature specific command dword15 field
* @data_len: Length of feature data, if applicable, in bytes
* @save: Save value across power states
* @uuidx: UUID Index for differentiating vendor specific encoding
* @fid: Feature identifier
*/
struct nvme_set_features_args {
__u32 *result;
void *data;
int args_size;
__u32 timeout;
__u32 nsid;
__u32 cdw11;
__u32 cdw12;
__u32 cdw13;
__u32 cdw15;
__u32 data_len;
bool save;
__u8 uuidx;
__u8 fid;
};

/**
* struct nvme_get_features_args - Arguments for the NVMe Admin Get Feature command
* @args_size: Size of &struct nvme_get_features_args
Expand Down
2 changes: 0 additions & 2 deletions src/nvme/fabrics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,7 +1225,6 @@ int nvmf_get_discovery_log(nvme_ctrl_t c, struct nvmf_discovery_log **logp,
struct nvme_get_discovery_args args = {
.c = c,
.max_retries = max_retries,
.timeout = NVME_DEFAULT_IOCTL_TIMEOUT,
.lsp = NVMF_LOG_DISC_LSP_NONE,
};

Expand Down Expand Up @@ -1604,7 +1603,6 @@ static int nvmf_dim(nvme_ctrl_t c, enum nvmf_dim_tas tas, __u8 trtype,
struct nvme_dim_args args = {
.args_size = sizeof(args),
.result = result,
.timeout = NVME_DEFAULT_IOCTL_TIMEOUT,
.tas = tas
};

Expand Down
Loading