decode: Fix the parameters passed to InitVulkanDecoderDevice #184
Conversation
srinathkr-nv
left a comment
srinathkr-nv
left a comment
There was a problem hiding this comment.
Can you explain the need for all the changes related to DecoderConfig::noPresent, such as the explicit checks against 0 instead of the existing bool-like checks? This will make it different from the handling for all other single-bit fields in DecoderConfig, such as directMode, validate etc.
Also, this change seems to be a regression since 28d581b. If that's accurate, please mention that in the commit message.
zlatinski
force-pushed
the
fix-InitVulkanDecoderDevice
branch
from
f6e8f46 to
69a0ceb
Compare
Fix the parameters passed to InitVulkanDecoderDevice() from the applications. This is a regression since 28d581b (28d581b) where there was a change that added a codec to the InitVulkanDecoderDevice() but did not update all of the clients. Also, fix codec extension handling in InitVulkanDecoderDevice When InitVulkanDecoderDevice is called with a specific codec flag (e.g., VK_VIDEO_CODEC_OPERATION_DECODE_H264_BIT_KHR), only that codec's extension should be required. Previously, the code used separate 'if' statements which meant all conditions were evaluated independently. This was incorrect because the videoCodecs parameter is typically a single codec flag, not a bitmask of multiple codecs. - Convert separate 'if' statements to 'else if' chain for mutually exclusive codec selection - Add 'else' branch for when videoCodecs is VK_VIDEO_CODEC_OPERATION_NONE_KHR or VIDEO_CODEC_OPERATIONS_ALL (0 or all bits set) - In the else case, add all codec extensions as OPTIONAL rather than required, allowing the device to support whatever codecs are available This fixes device initialization when the caller doesn't know the specific codec ahead of time (e.g., auto-detection scenarios). Signed-off-by: Tony Zlatinski <[email protected]>
zlatinski
force-pushed
the
fix-InitVulkanDecoderDevice
branch
from
69a0ceb to
2d56c8c
Compare
|
Thank you, for looking at this change!
There was an issue with the default parameters converting from int bitfiled to integer, which is natural. This was me debugging the issue. I reverted this change.
I have added the reference to the change that has caused the regression. |
Fix the parameters passed to InitVulkanDecoderDevice() from the applications.
There was a change that added a codec to the InitVulkanDecoderDevice() but did not update all of the clients.