Increment flash write address and correct write size #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fsl_c40_flash.c: Initialize `ret` in FLASH_Erase() to
`kStatus_FLASH_Success` to avoid potential use-before-set warnings on some
toolchains/static analyzers (no functional change).
- S32K344_features.h: Define C40 array geometry for S32K344 using unsigned
constants:
* FSL_FEATURE_FLASH_C40_BLOCK_SIZE_CODE (1 MiB)
* FSL_FEATURE_FLASH_C40_BLOCK_COUNT_CODE (4)
* FSL_FEATURE_FLASH_C40_BLOCK_SIZE_DATA (256 KiB)
Note: erase/program granularities are controller-level and handled by driver.
- S32K344_glue_mcux.h: Provide conditional aliases mapping FLASH↔IP_FLASH and
PFLASH↔IP_PFLASH to harmonize SDK naming and improve build portability.
Signed-off-by: Sumit Batra <[email protected]>
sumitbatra-nxp
force-pushed
the
c40_flash_hal_nxp_1
branch
from
c51a5eb to
64395f5
Compare
sumitbatra-nxp
force-pushed
the
c40_flash_hal_nxp_1
branch
6 times, most recently
from
50cc6f6 to
59a3b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was discovered while testing serial DFU with MCUBoot on the branch
c40_flash_hal_nxp_1. These changes allow serial DFU to complete successfully.Without this fix serial DFU hangs indefinitely.