Skip to content

Conversation

dannywillems
Copy link
Member

Add comprehensive macOS support to the developer documentation by:

  • Creating platform-specific setup scripts for macOS using Homebrew
  • Splitting installation instructions using tabbed interface for Linux and macOS
  • Adding macOS CI testing jobs to verify setup scripts work correctly
  • Renaming CI jobs for clarity (ubuntu, macos, docker-ubuntu, docker-macos)

This enables macOS developers to easily set up their development environment
with proper platform-specific installation commands.

@dannywillems dannywillems force-pushed the dw/update-instructions-build branch from 618209c to 968a7d5 Compare July 24, 2025 13:35
@dannywillems dannywillems force-pushed the dw/update-instructions-build branch from 968a7d5 to fe5b82b Compare July 24, 2025 13:46
@dannywillems dannywillems changed the base branch from dw/update-docs to develop July 24, 2025 14:09
@dannywillems dannywillems force-pushed the dw/update-instructions-build branch from fe5b82b to c52f0be Compare July 24, 2025 14:09
@dannywillems dannywillems enabled auto-merge July 24, 2025 14:09
@dannywillems dannywillems mentioned this pull request Jul 24, 2025
@dannywillems
Copy link
Member Author

Removing the -b option as:

ln: illegal option -- b
usage: ln [-s [-F] | -L | -P] [-f | -i] [-hnv] source_file [target_file]
       ln [-s [-F] | -L | -P] [-f | -i] [-hnv] source_file ... target_dir
       link source_file target_file
make: *** [download-circuits] Error 1

Source: OpenMina CI

@dannywillems
Copy link
Member Author

dannywillems commented Jul 24, 2025

Investigating

error: "/Users/runner/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/Cargo.lock" does not exist, unable to build with the standard library, try:
        rustup component add rust-src --toolchain nightly-aarch64-apple-darwin
make: *** [build-wasm] Error 101
Building testing framework...

It seems it is also present for Ubuntu. The error hasn't been caught before.
Fixed in d312f25

@dannywillems dannywillems force-pushed the dw/update-instructions-build branch from 603d539 to 19f55dd Compare July 24, 2025 21:19
@dannywillems dannywillems force-pushed the dw/update-instructions-build branch 2 times, most recently from 650a7d3 to ce3d541 Compare July 25, 2025 09:18
@dannywillems dannywillems force-pushed the dw/update-instructions-build branch from ce3d541 to 62d1890 Compare July 25, 2025 10:09
Add comprehensive macOS support to the developer documentation by:
- Creating platform-specific setup scripts for macOS using Homebrew
- Splitting installation instructions using tabbed interface for Linux and macOS
- Adding macOS CI testing jobs to verify setup scripts work correctly
- Renaming CI jobs for clarity (ubuntu, macos, docker-ubuntu, docker-macos)

This enables macOS developers to easily set up their development environment
with proper platform-specific installation commands.
It does seem necessary also for this command.
Add taplo-cli (TOML formatter) to the Rust installation script and update
developer documentation to explain what tools are installed.

This fixes the 'make: taplo: No such file or directory' error when running
make format commands.

- Added taplo-cli installation to install-rust.sh
- Updated getting-started.mdx to list installed tools and their purpose
- taplo-cli is required for make format to work with TOML files
Add comprehensive instructions for testing developer setup scripts using
the test-doc-scripts workflow. This ensures documentation stays current
and prevents broken installation instructions.

Includes:
- When to test (script modifications, new dependencies, new platforms)
- How to trigger tests using GitHub labels and CLI
- What gets tested across platforms
- Motivation for on-demand testing approach

This helps maintain reliable developer onboarding documentation.
Add documentation and automation for SQLite database setup required
by the heartbeats processor when running 'make check' or 'make lint'.

Changes:
- Added SQLite database setup section to developer documentation
- Updated format-and-lint.sh script to automatically create the database
- Referenced tools/heartbeats-processor/schema.sql for schema creation
- Set DATABASE_URL environment variable as required by SQLx

This prevents 'database connection failed' errors when developers
run make check/lint commands.
And redirect to the CI instead.
The tests take too much time to run, and it is useless as it is tested in the CI.
@dannywillems
Copy link
Member Author

The CI is all green, and it seems to pass all tests on MacOS.
I will bypass the rules to move on as some PRs are blocked by this one.
If any issue arises from this, I would personally fix it.

@dannywillems dannywillems merged commit 62238de into develop Jul 25, 2025
49 checks passed
@dannywillems dannywillems deleted the dw/update-instructions-build branch October 16, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants