-
Notifications
You must be signed in to change notification settings - Fork 40
Docs: add macOS instructions to developer getting-started guide #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
618209c
to
968a7d5
Compare
968a7d5
to
fe5b82b
Compare
fe5b82b
to
c52f0be
Compare
Merged
Removing the
Source: OpenMina CI |
Investigating
It seems it is also present for Ubuntu. The error hasn't been caught before. |
603d539
to
19f55dd
Compare
650a7d3
to
ce3d541
Compare
ce3d541
to
62d1890
Compare
Add comprehensive macOS support to the developer documentation by: - Creating platform-specific setup scripts for macOS using Homebrew - Splitting installation instructions using tabbed interface for Linux and macOS - Adding macOS CI testing jobs to verify setup scripts work correctly - Renaming CI jobs for clarity (ubuntu, macos, docker-ubuntu, docker-macos) This enables macOS developers to easily set up their development environment with proper platform-specific installation commands.
It does seem necessary also for this command.
Add taplo-cli (TOML formatter) to the Rust installation script and update developer documentation to explain what tools are installed. This fixes the 'make: taplo: No such file or directory' error when running make format commands. - Added taplo-cli installation to install-rust.sh - Updated getting-started.mdx to list installed tools and their purpose - taplo-cli is required for make format to work with TOML files
Add comprehensive instructions for testing developer setup scripts using the test-doc-scripts workflow. This ensures documentation stays current and prevents broken installation instructions. Includes: - When to test (script modifications, new dependencies, new platforms) - How to trigger tests using GitHub labels and CLI - What gets tested across platforms - Motivation for on-demand testing approach This helps maintain reliable developer onboarding documentation.
Add documentation and automation for SQLite database setup required by the heartbeats processor when running 'make check' or 'make lint'. Changes: - Added SQLite database setup section to developer documentation - Updated format-and-lint.sh script to automatically create the database - Referenced tools/heartbeats-processor/schema.sql for schema creation - Set DATABASE_URL environment variable as required by SQLx This prevents 'database connection failed' errors when developers run make check/lint commands.
And redirect to the CI instead. The tests take too much time to run, and it is useless as it is tested in the CI.
62d1890
to
94e556e
Compare
The CI is all green, and it seems to pass all tests on MacOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive macOS support to the developer documentation by:
This enables macOS developers to easily set up their development environment
with proper platform-specific installation commands.