CI: add shellcheck #1255
Merged
CI: add shellcheck #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/add-shellcheck
branch
from
41e9396 to
88c13b5
Compare
dannywillems
commented
Jul 25, 2025
| @find . -name "*.sh" \ | ||
| -not -path "*/target/*" \ | ||
| -not -path "*/node_modules/*" \ | ||
| -not -path "*/website/docs/developers/scripts/setup/*" \ |
There was a problem hiding this comment.
The scripts we provide to the developers should be ignored as they do not to be executables, and shellcheck will complain.
dannywillems
force-pushed
the
dw/add-shellcheck
branch
from
dddcd54 to
22ad72d
Compare
Replace exit code checking pattern from '\! cmd' to using variables for better code clarity. Wrap long command lines at 80 characters and ensure proper variable quoting to comply with shellcheck recommendations. - Use curl_exit_code, sed_exit_code, tar_exit_code variables - Fix SC2181 violations by avoiding $? checks - Fix SC2086 violations by adding quotes around variables - Improve readability with proper line wrapping
dannywillems
force-pushed
the
dw/add-shellcheck
branch
from
22ad72d to
64ed658
Compare
volhovm
approved these changes
Jul 25, 2025
| cargo clippy --all-targets -- -D warnings --allow clippy::mutable_key_type | ||
|
|
||
| .PHONY: lint-bash | ||
| lint-bash: ## Check all shell scripts using shellcheck |
There was a problem hiding this comment.
This works for me.
Should we also add shellcheck into install-system-deps.sh? I'd definitely add it to the flake.nix since it's something that developers might want to run locally.
There was a problem hiding this comment.
Good point for the doc!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the lint issues now.