Skip to content

Conversation

0xMimir
Copy link
Contributor

@0xMimir 0xMimir commented Aug 13, 2025

Update proof systems and algebra to new version

@0xMimir 0xMimir force-pushed the feat/update-proof-systems branch 18 times, most recently from 6662c7a to be3ed6a Compare August 14, 2025 12:29
@dannywillems dannywillems force-pushed the feat/update-proof-systems branch from 576c591 to 93e94f4 Compare August 14, 2025 13:56
@0xMimir 0xMimir force-pushed the feat/update-proof-systems branch 11 times, most recently from de3df2a to 7738a15 Compare August 20, 2025 13:12
o1-utils = { git = "https://github.com/openmina/proof-systems", rev = "f461b4b" }
poly-commitment = { git = "https://github.com/openmina/proof-systems", rev = "f461b4b" }
# UNCOMMENTED_IN_CI mina-curves = { git = "https://github.com/openmina/proof-systems", rev = "d1912bca54d2609296b9af9d09ad1ef78702e203", features = [ "32x9" ] }
kimchi = { git = "https://github.com/openmina/proof-systems", rev = "d1912bca54d2609296b9af9d09ad1ef78702e203" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described in the issue #1153, we would like to remove this dependency on openmina/proof-systems, and rely on o1-labs/proof-systems. We need to backport the changes into o1-labs/proof-systems.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From openmina/proof-systems@4362faa, I don't understand:
image
nor
image

Copy link
Member

@dannywillems dannywillems Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #1367, but it would require your approvals on o1-labs/proof-systems#3328 and o1-labs/proof-systems#3326

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the Self::to_biguint there was a weird compilation issue, where for some reason the function was not found

@dannywillems
Copy link
Member

From the fork of openmina/proof-systems: secret_multiply_with_curve_point can be removed, as now we have the field secret public in mina-signer. You can use directly the code:

let scaled_message_hash = vrf_message_hash_curve_point.mul(producer_key.secret.into_scalar()).into_affine()

@0xMimir 0xMimir force-pushed the feat/update-proof-systems branch 2 times, most recently from a698357 to 71fb876 Compare September 2, 2025 12:45
@0xMimir 0xMimir force-pushed the feat/update-proof-systems branch 2 times, most recently from db8984f to c4c49d5 Compare September 3, 2025 12:30
@0xMimir 0xMimir force-pushed the feat/update-proof-systems branch from c4c49d5 to ff9e4d3 Compare September 4, 2025 10:59
@dannywillems
Copy link
Member

Timeout for bootstrap-test, record-replay-tests and scenario-tests are increased in another PR.
scenario-tests is failing, we will have to fix it in a follow-up. Accepting as is for now.

@dannywillems dannywillems merged commit a2d5dad into develop Sep 4, 2025
54 of 58 checks passed
@dannywillems dannywillems moved this to Done in Rust node Sep 17, 2025
@dannywillems dannywillems mentioned this pull request Oct 8, 2025
44 tasks
@dannywillems dannywillems deleted the feat/update-proof-systems branch October 16, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants