Feat/update proof systems #1299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xMimir
force-pushed
the
feat/update-proof-systems
branch
18 times, most recently
from
6662c7a to
be3ed6a
Compare
dannywillems
force-pushed
the
feat/update-proof-systems
branch
from
576c591 to
93e94f4
Compare
0xMimir
force-pushed
the
feat/update-proof-systems
branch
11 times, most recently
from
de3df2a to
7738a15
Compare
0xMimir
force-pushed
the
feat/update-proof-systems
branch
9 times, most recently
from
a5a4acd to
7f9ea4f
Compare
0xMimir
commented
Aug 22, 2025
0xMimir
commented
Aug 25, 2025
0xMimir
commented
Aug 25, 2025
| } | ||
| BinOp(Op2::Sub, x, y) => { | ||
| // TODO_NOT_SURE | ||
| Operations::Atom(_) => {} |
There was a problem hiding this comment.
Not sure what I should do here, since type of Atom(T) if different from e, I could implement something similar to eval and sub_eval where sub_extract_caches is same as extract_caches but on type of T
0xMimir
commented
Aug 25, 2025
0xMimir
force-pushed
the
feat/update-proof-systems
branch
3 times, most recently
from
3015c32 to
c20d58a
Compare
There was a problem hiding this comment.
A consequence of merging this would be to come back on nightly, instead of a fixed version as done in #1348. ark-ff 0.3.0 depends on hasbrown 0.11.2, and we get
error: `#[inline]` attribute cannot be used on macro calls
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hashbrown-0.11.2/src/raw/mod.rs:1539:41
|
1539 | #[cfg_attr(feature = "inline-more", inline)]
| ^^^^^^
|
= help: `#[inline]` can only be applied to functions
from the nightly version of Rust from yesterday (2025-08-24).
0xMimir
force-pushed
the
feat/update-proof-systems
branch
from
38fcab6 to
7c41550
Compare
volhovm
reviewed
Aug 26, 2025
0xMimir
force-pushed
the
feat/update-proof-systems
branch
from
7c41550 to
fd88d24
Compare
0xMimir
force-pushed
the
feat/update-proof-systems
branch
from
fd88d24 to
a2ed9dd
Compare
0xMimir
force-pushed
the
feat/update-proof-systems
branch
from
a2ed9dd to
f46584d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update proof systems and algebra to new version