-
Notifications
You must be signed in to change notification settings - Fork 40
Feat/update proof systems #1299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6662c7a
to
be3ed6a
Compare
576c591
to
93e94f4
Compare
de3df2a
to
7738a15
Compare
o1-utils = { git = "https://github.com/openmina/proof-systems", rev = "f461b4b" } | ||
poly-commitment = { git = "https://github.com/openmina/proof-systems", rev = "f461b4b" } | ||
# UNCOMMENTED_IN_CI mina-curves = { git = "https://github.com/openmina/proof-systems", rev = "d1912bca54d2609296b9af9d09ad1ef78702e203", features = [ "32x9" ] } | ||
kimchi = { git = "https://github.com/openmina/proof-systems", rev = "d1912bca54d2609296b9af9d09ad1ef78702e203" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As described in the issue #1153, we would like to remove this dependency on openmina/proof-systems, and rely on o1-labs/proof-systems. We need to backport the changes into o1-labs/proof-systems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1299 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From openmina/proof-systems@4362faa, I don't understand:
nor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created #1367, but it would require your approvals on o1-labs/proof-systems#3328 and o1-labs/proof-systems#3326
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the Self::to_biguint
there was a weird compilation issue, where for some reason the function was not found
From the fork of openmina/proof-systems:
|
a698357
to
71fb876
Compare
Co-authored-by: Danny Willems <[email protected]>
db8984f
to
c4c49d5
Compare
c4c49d5
to
ff9e4d3
Compare
Timeout for bootstrap-test, record-replay-tests and scenario-tests are increased in another PR. |
Update proof systems and algebra to new version