Skip to content

fix(curves): allow asm cfg from ark-ff derive macros #3377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dannywillems wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(curves): allow asm cfg from ark-ff derive macros #3377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions curves/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ readme = "../README.md"
edition = "2021"
license = "Apache-2.0"

[lints.rust]
Copy link

@iostat iostat Dec 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious on the motivation for adding this as a lint exemption as opposed to explicitly listing the features in the crate manifest. My understanding is that derive macros are producing these feature-gates which aren't explicitly listed and the linter isn't pleased with that. But from a tooling perspective, the lint is absolutely correct in that code is being produced which may never be enabled because the corresponding features aren't defined.

I believe the following would be the idiomatic way to resolve the warning which preserves the lint's intent.

[features]
asm = []

unexpected_cfgs = { level = "warn", check-cfg = [
"cfg(feature, values(\"asm\"))",
] }

[dependencies]
ark-bn254.workspace = true
ark-ec.workspace = true
Expand Down
Loading