Skip to content

fix: xgboost raw parser#518

Merged
wrigleyDan merged 1 commit intoo19s:mainfrom
cdmbr:fix/xgboost-raw-parser
Oct 17, 2025
Merged

fix: xgboost raw parser#518
wrigleyDan merged 1 commit intoo19s:mainfrom
cdmbr:fix/xgboost-raw-parser

Conversation

@cdmbr
Copy link
Contributor

@cdmbr cdmbr commented Aug 1, 2025

models loaded with xgboost raw parser are generating wrong results due to split node misconfiguration.

  • handles missing nodes properly
  • the 5th parameter of NaiveAdditiveDecisionTree.Split is leftNodeId (it was using the featureId)

@cdmbr
Copy link
Contributor Author

cdmbr commented Aug 1, 2025

fyi: @pltb

@wrigleyDan wrigleyDan merged commit 251b1a0 into o19s:main Oct 17, 2025
1 check passed
@wrigleyDan wrigleyDan mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants