Skip to content

fix: xgboost raw parser #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: xgboost raw parser #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/main/java/com/o19s/es/ltr/ranker/parser/XGBoostRawJsonParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ public class XGBoostRawJsonParser implements LtrRankerParser {

public static final String TYPE = "model/xgboost+json+raw";

private static final Integer MISSING_NODE_ID = Integer.MAX_VALUE;

@Override
public NaiveAdditiveDecisionTree parse(FeatureSet set, String model) {
XGBoostRawJsonParser.XGBoostDefinition modelDefinition;
Expand Down Expand Up @@ -439,8 +437,16 @@ private NaiveAdditiveDecisionTree.Node asLibTree(Integer nodeId) {
}

if (isSplit(nodeId)) {
return new NaiveAdditiveDecisionTree.Split(asLibTree(leftChildren.get(nodeId)), asLibTree(rightChildren.get(nodeId)),
splitIndices.get(nodeId), splitConditions.get(nodeId), splitIndices.get(nodeId), MISSING_NODE_ID);
Integer missingNodeId =
defaultLeft.get(nodeId) == 1 ? leftChildren.get(nodeId) : rightChildren.get(nodeId);
return new NaiveAdditiveDecisionTree.Split(
asLibTree(leftChildren.get(nodeId)),
asLibTree(rightChildren.get(nodeId)),
splitIndices.get(nodeId),
splitConditions.get(nodeId),
leftChildren.get(nodeId),
missingNodeId
);
} else {
return new NaiveAdditiveDecisionTree.Leaf(baseWeights.get(nodeId));
}
Expand Down