Skip to content

Conversation

@abukosek
Copy link
Contributor

@abukosek abukosek commented Nov 6, 2025

Closes #589 and closes #590.

If artifacts.builder is set in rofl.yaml, the given Docker image is now pulled at the start of the rofl build process and the progress of the Docker layer pulling is also shown in real-time, so the user knows what is going on.

Example output with artifacts.builder set to ghcr.io/oasisprotocol/rofl-dev:main-minimal:

Deployment: test
Network:    testnet
ParaTime:   sapphire
Debug:      false
App ID:     rofl1qp55evqls4qg6cjw5fnlv4al9ptc0fsakvxvd9uw
Name:       demo-rofl
Version:    0.2.0
TEE:        tdx
Kind:       container

Initializing build environment...
Unable to find image 'ghcr.io/oasisprotocol/rofl-dev:main-minimal' locally
main-minimal: Pulling from oasisprotocol/rofl-dev
1adabd6b0d6b: Pull complete 
98807ed13a7f: Pull complete 
e9511b254cfc: Pull complete 
Digest: sha256:2a93fa747fa5e2735d6fbdbbd1179dc077ebfcbb14df2694513c1cce96cb06c2
Status: Downloaded newer image for ghcr.io/oasisprotocol/rofl-dev:main-minimal
Building a container-based TDX ROFL application...
[...]

@netlify
Copy link

netlify bot commented Nov 6, 2025

Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit eafe915
🔍 Latest deploy log https://app.netlify.com/projects/oasisprotocol-cli/deploys/690de53b6d2f91000911db0f

@abukosek abukosek marked this pull request as ready for review November 6, 2025 14:06
@abukosek abukosek requested a review from matevz November 6, 2025 14:07
@abukosek abukosek force-pushed the andrej/feature/rofl-build-docker-progress branch 2 times, most recently from f5de7b7 to 4db7726 Compare November 6, 2025 15:13
@abukosek abukosek requested a review from ptrus November 6, 2025 15:54
@abukosek abukosek force-pushed the andrej/feature/rofl-build-docker-progress branch from 4db7726 to adc7992 Compare November 7, 2025 12:19
@abukosek abukosek force-pushed the andrej/feature/rofl-build-docker-progress branch from adc7992 to eafe915 Compare November 7, 2025 12:25
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks.

@abukosek abukosek merged commit 085bb7b into master Nov 7, 2025
5 checks passed
@abukosek abukosek deleted the andrej/feature/rofl-build-docker-progress branch November 7, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants