Skip to content

cmd/rofl/build: Pull builder Docker image at start and show progress #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abukosek merged 1 commit into from
Nov 7, 2025
Merged

cmd/rofl/build: Pull builder Docker image at start and show progress #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions cmd/rofl/build/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"fmt"
"maps"
"os"
"os/exec"
"slices"

"github.com/spf13/cobra"
Expand Down Expand Up @@ -68,6 +69,7 @@ var (
fmt.Printf("Version: %s\n", manifest.Version)
fmt.Printf("TEE: %s\n", manifest.TEE)
fmt.Printf("Kind: %s\n", manifest.Kind)
fmt.Println()

switch deployment.Debug {
case true:
Expand Down Expand Up @@ -104,6 +106,24 @@ var (
)
containerEnv.AddDirectory(tmpDir)
buildEnv = containerEnv

if buildEnv.IsAvailable() {
fmt.Printf("Initializing build environment...\n")
// Run a dummy command to make sure that all necessary Docker layers
// for the build environment are downloaded at the start instead of
// later in the build process.
// Also pipe all output from the process to stdout/stderr, so the user
// can follow the progress in real-time.
cmd := exec.Command("true")
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
if err = buildEnv.WrapCommand(cmd); err != nil {
return fmt.Errorf("unable to wrap command: %w", err)
}
if err = cmd.Run(); err != nil {
return fmt.Errorf("failed to initialize build environment: %w", err)
}
}
}

if !buildEnv.IsAvailable() {
Expand Down
Loading