fix(rofl-appd): improve transaction field deserialization flexibility #2416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uniyalabhishek
requested review from
kostko,
matevz,
peternose and
ptrus
as code owners
✅ Deploy Preview for oasisprotocol-oasis-sdk ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2416 +/- ##
==========================================
+ Coverage 48.33% 48.40% +0.06%
==========================================
Files 223 223
Lines 15902 15935 +33
==========================================
+ Hits 7686 7713 +27
- Misses 8156 8162 +6
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matevz
reviewed
Dec 10, 2025
Member
matevz
left a comment
matevz
left a comment
There was a problem hiding this comment.
IMO there is too much critical code like parsing numbers and hex values which is already implemented in the ethereum-types, serde and hex crates. We already include all of them from the oasis-runtime-sdk-evm crate.
uniyalabhishek
force-pushed
the
uniyalabhishek/rofl-appd/fix-txn-submit
branch
3 times, most recently
from
b003b06 to
4f4a541
Compare
matevz
reviewed
Dec 11, 2025
Member
|
FYI the python encryption field was moved to a separate #2418 |
uniyalabhishek
force-pushed
the
uniyalabhishek/rofl-appd/fix-txn-submit
branch
from
feb340d to
7778cfa
Compare
ptrus
reviewed
Dec 15, 2025
Member
ptrus
left a comment
ptrus
left a comment
There was a problem hiding this comment.
Looks mostly good, left a couple of minor suggestions!
feat(rofl-appd): add hex dep and simplify hex string deserialization test(rofl-appd): add additional test for large ROSE transaction value fix(rofl-appd): feedback changes
uniyalabhishek
force-pushed
the
uniyalabhishek/rofl-appd/fix-txn-submit
branch
from
d5139ef to
9bcb89b
Compare
ptrus
approved these changes
Dec 17, 2025
ptrus
approved these changes
Dec 17, 2025
github-actions bot
added a commit
that referenced
this pull request
Dec 17, 2025
…niyalabhishek/rofl-appd/fix-txn-submit fix(rofl-appd): improve transaction field deserialization flexibility b89a8af
github-actions bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Dec 17, 2025
…sisprotocol/uniyalabhishek/rofl-appd/fix-txn-submit fix(rofl-appd): improve transaction field deserialization flexibility b89a8af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix transaction deserialization issues causing 422 errors in ROFL appd
u128tou64inTransactionValueenum (serde_json doesn't supportu128in untagged enums). Large values must use string format.