Merged
Conversation
Merged
Deployed to Cloudflare Pages
|
lukaw3d
force-pushed
the
lw/fix-small-withdrawals
branch
4 times, most recently
from
c520df1 to
8d84686
Compare
lubej
reviewed
Feb 26, 2025
| import { SapphireAccount } from './useGenerateSapphireAccount' | ||
|
|
||
| const withdrawFeeAmount = sapphireConfig.gasPrice * sapphireConfig.feeGas * multiplyConsensusToSapphire | ||
| export const withdrawFeeAmount = sapphireConfig.gasPrice * sapphireConfig.feeGas * multiplyConsensusToSapphire |
Collaborator
There was a problem hiding this comment.
Why is sapphireConfig.feeGas defined as 70k? Usually transfers take like 20k units of gas (https://support.metamask.io/more-web3/learn/how-to-estimate-the-gas-fee/#getting-the-gas-limit - 21k to be exact). Is there anything different on Sapphire?
Contributor
There was a problem hiding this comment.
buberdds
approved these changes
Feb 27, 2025
added 6 commits
February 27, 2025 20:05
lukaw3d
force-pushed
the
lw/fix-small-withdrawals
branch
from
8c01ec6 to
19b49ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #155
Fixes #199
Now correctly warns that 0.015 amount is too low; 0.01700001 works. I was still more comfortable with a higher limit at #87 tho.