Add `normalize` command. by aidarkdev · Pull Request #879 · objectionary/eoc

aidarkdev · 2026-03-09T17:59:58Z

Closes #590

Add normalize command. Works via calling phino util.

- refactor files ops funcs - log every step timestamps - add check params existing

- fix tests for changes

aidarkdev · 2026-03-12T16:26:24Z

@yegor256 @maxonfjvipon take a look plz.
Phino win binary is available now and all checks are ok.

maxonfjvipon · 2026-03-13T09:55:33Z

src/files.js

+  }
+  return result;
+}
+module.exports.findFiles = findFiles;


@aidarkdev let's use single module.exports at the end of the file

maxonfjvipon · 2026-03-13T09:59:34Z

src/commands/normalize.js

+  const target = path.resolve(opts.target);
+  return elapsed(async (tracked) => {
+    copyDir(sources, path.join(target, 'before-normalize'), '.eo');
+    const xmirDir = path.join(target, '1-parse');


@aidarkdev let's try to use single named variable as much as possible, parsed instead of xmirDir, xmirs instead of xmirFile, rel instead of relPath, xmir instead of xmirFile and so on. Check this: https://www.yegor256.com/2015/01/12/compound-name-is-code-smell.html

maxonfjvipon · 2026-03-13T10:02:21Z

src/commands/normalize.js

+    console.debug('Found %d XMIR file(s) to normalize', xmirFiles.length);
+    for (const xmirFile of xmirFiles) {
+      const relPath = path.relative(xmirDir, xmirFile);
+      const base = relPath.replace(/\.xmir$/, '');


@aidarkdev I think there's a special function in path module for getting relative path

@maxonfjvipon you are rigth, there is alredy used relative funct, replace was just redundant code(that cutted file extension), it is deleted for now

maxonfjvipon · 2026-03-13T10:04:20Z

src/commands/normalize.js

+      console.debug('Normalizing %s', relPath);
+      let ts = Date.now();
+      const phi = execSync(
+        'phino rewrite --input=xmir --output=phi',


@aidarkdev there's no need to call phino a several times. You can just do:

phino rewrite --input=xmir --output=xmir --normalize your-file

@maxonfjvipon on first version were debug mode where every phino call result can be saved. Now we can use one singel call, yes. Thanks! fixed

maxonfjvipon · 2026-03-13T10:07:01Z

test/commands/test_normalize.js

+    fs.rmSync(home, {recursive: true, force: true});
+    fs.mkdirSync(source, {recursive: true});
+    fs.mkdirSync(target, {recursive: true});
+    const content = '# sample\n[] > simple\n';


@aidarkdev I see a lot of code duplication across the tests:

const home = path.resolve('temp/test-normalize/simple'); const source = path.resolve(home, 'src'); const target = path.resolve(home, 'target'); fs.rmSync(home, {recursive: true, force: true}); fs.mkdirSync(source, {recursive: true}); fs.mkdirSync(target, {recursive: true}); const content = '# sample\n[] > simple\n';

I think it can be moved to some preparation function

The same story with:

runSync([ 'normalize', '--verbose', `--parser=${parserVersion}`, `--home-tag=${homeTag}`, '-s', source, '-t', target, ]);

- single export - single `phino` call on normalize command - cut code duplication on tests

- back tests skipped before for debug - fix link to latest phino binary

aidarkdev · 2026-03-17T07:38:09Z

@maxonfjvipon review comments fixed, all debug logs and other workaround cleaned, checks-tests are ok

maxonfjvipon

@aidarkdev looks good, just one minor fix and we're good to merge

maxonfjvipon · 2026-03-17T08:35:20Z

src/files.js

+  if (!fs.existsSync(src)) {return;}
+  fs.mkdirSync(dst, {recursive: true});
+  for (const entry of fs.readdirSync(src, {withFileTypes: true})) {
+    const srcPath = path.join(src, entry.name);


@aidarkdev let's use single word name also here source instead of srcPath and dest or destination instead of dstPath

@maxonfjvipon thanks!
Fixed. All checks-tests are ok.

maxonfjvipon · 2026-03-18T13:31:20Z

@aidarkdev the only man who can merge the PR is @yegor256. So do be shy, ping him

aidarkdev · 2026-03-19T03:41:46Z

@yegor256 need to merge here

aidarkdev · 2026-03-19T15:05:14Z

@yegor256 ping, review ok, need to push here

aidarkdev · 2026-03-20T17:56:09Z

@yegor256 review ok, waiting merge

yegor256 · 2026-03-20T20:55:49Z

@rultor merge

rultor · 2026-03-21T04:38:12Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here.

rultor · 2026-03-21T05:02:22Z

@rultor merge

@aidarkdev @yegor256 Oops, I failed. You can see the full log here (spent 23min).

  \u001b[32m  ✓\u001b[0m\u001b[90m fails due version mismatch if different --pin provided\u001b[0m\u001b[31m (952ms)\u001b[0m

\u001b[0m  eoc\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m cleans successfully when versions match with --pin\u001b[0m\u001b[31m (952ms)\u001b[0m

\u001b[0m  eoc\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m cleans successfully when if --pin not provided\u001b[0m\u001b[31m (971ms)\u001b[0m

\u001b[0m  mvnw\u001b[0m
Running mvnw with arguments: --version --quiet
+ /home/r/repo/mvnw/mvnw --version --quiet --batch-mode --color=never --fail-fast --strict-checksums
\u001b[0m\u001b[0m3.9.14
\u001b[0m\u001b[0m  \u001b[32m  ✓\u001b[0m\u001b[90m prints Maven own version\u001b[0m\u001b[31m (312ms)\u001b[0m
Sources in sources
Target in target
Running mvnw with arguments: --version --quiet -Deo.version=0.28.11 -Deo.tag=homeTag --quiet -Deo.sourcesDir=/home/r/repo/sources -Deo.targetDir=/home/r/repo/target -Deo.outputDir=/home/r/repo/target/classes -Deo.generatedDir=/home/r/repo/target/generated-sources -Deo.placed=/home/r/repo/target/eo-placed.csv -Deo.placedFormat=csv -Deo.skipLinting=false
+ /home/r/repo/mvnw/mvnw --version --quiet -Deo.version=0.28.11 -Deo.tag=homeTag --quiet -Deo.sourcesDir=/home/r/repo/sources -Deo.targetDir=/home/r/repo/target -Deo.outputDir=/home/r/repo/target/classes -Deo.generatedDir=/home/r/repo/target/generated-sources -Deo.placed=/home/r/repo/target/eo-placed.csv -Deo.placedFormat=csv -Deo.skipLinting=false --batch-mode --color=never --fail-fast --strict-checksums
\u001b[0m\u001b[0m3.9.14
\u001b[0m\u001b[0m  \u001b[32m  ✓\u001b[0m\u001b[90m sets right flags from options\u001b[0m\u001b[31m (458ms)\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m should handle ENOENT race condition in count function\u001b[0m

\u001b[0m  parser-version\u001b[0m
\u001b[0m    get()\u001b[0m
The latest version of org/eolang/eo-maven-plugin at https://repo.maven.apache.org/maven2/org/eolang/eo-maven-plugin/maven-metadata.xml is 0.59.5
    \u001b[32m  ✓\u001b[0m\u001b[90m fetches the latest version from Maven Central\u001b[0m\u001b[31m (89ms)\u001b[0m
    \u001b[32m  ✓\u001b[0m\u001b[90m caches the version after first fetch\u001b[0m
\u001b[0m    exists()\u001b[0m
    \u001b[32m  ✓\u001b[0m\u001b[90m returns true for a known valid version\u001b[0m\u001b[33m (73ms)\u001b[0m
    \u001b[32m  ✓\u001b[0m\u001b[90m returns true for current default version\u001b[0m\u001b[31m (79ms)\u001b[0m
    \u001b[32m  ✓\u001b[0m\u001b[90m returns false for an obviously invalid version\u001b[0m\u001b[31m (85ms)\u001b[0m
    \u001b[32m  ✓\u001b[0m\u001b[90m returns false for undefined version\u001b[0m
    \u001b[32m  ✓\u001b[0m\u001b[90m returns false for null version\u001b[0m
    \u001b[32m  ✓\u001b[0m\u001b[90m returns false for empty string version\u001b[0m
    \u001b[32m  ✓\u001b[0m\u001b[90m returns false for "undefined" string\u001b[0m
    \u001b[32m  ✓\u001b[0m\u001b[90m constructs correct Maven Central URL\u001b[0m\u001b[31m (81ms)\u001b[0m
    \u001b[32m  ✓\u001b[0m\u001b[90m handles network errors gracefully\u001b[0m\u001b[33m (71ms)\u001b[0m

\u001b[0m  tinted-console\u001b[0m
\u001b[33mok\u001b[39m
  \u001b[32m  ✓\u001b[0m\u001b[90m allows console.warn without errors\u001b[0m


\u001b[92m \u001b[0m\u001b[32m 71 passing\u001b[0m\u001b[90m (6m)\u001b[0m
\u001b[36m \u001b[0m\u001b[36m 5 pending\u001b[0m
\u001b[31m  1 failing\u001b[0m

\u001b[0m  1) normalize
       "before all" hook for "normalizes EO files and saves originals in before-normalize/":
\u001b[0m\u001b[31m     Error: phino is required to run normalize tests, see https://github.com/objectionary/phino\u001b[0m\u001b[90m
      at Context.<anonymous> (test/commands/test_normalize.js:39:13)
      at GetAddrInfoReqWrap.callback (test/helpers.js:73:5)
      at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:109:8)
\u001b[0m


Warning:  Use --force to continue.

Aborted due to warnings.
\u001b[1G\u001b[0K⠙\u001b[1G\u001b[0Kcontainer f43a94332625368f0fb83ba571ca110b2d150f3f9ac4c456d6cce7693bf28eba is dead
Sat Mar 21 05:02:16 UTC 2026

maxonfjvipon · 2026-03-21T05:28:37Z

@yegor256 it seems phino has to be installed in Rultor

aidarkdev · 2026-03-21T13:23:07Z

@maxonfjvipon @yegor256 opened issue for that
yegor256/rultor#2285

aidarkdev · 2026-03-21T15:10:00Z

@maxonfjvipon @yegor256 opened issue for that yegor256/rultor#2285

@yegor256 @maxonfjvipon found out how it works, closed the issue. Added phino install to .rultor.yml file.
Checks/tests still ok, @yegor256 need to trigger merge one more time plz.

yegor256 · 2026-03-22T09:00:30Z

@aidarkdev thanks!

aidarkdev added 2 commits March 8, 2026 22:40

normalize command and tests

4acd364

- store every step files on debug mode

1c908fe

- refactor files ops funcs - log every step timestamps - add check params existing

aidarkdev changed the title ~~590~~ Add normalize command. Mar 9, 2026

md linter warn fix

2746370

aidarkdev marked this pull request as draft March 9, 2026 18:15

aidarkdev added 7 commits March 10, 2026 00:24

- fail tests if no phino util found

13d67ae

- cut debug option feature when transitional files saved

fd39adf

- fix tests for changes

- refactoring

9f0d2cf

- try binaries from forked phino repo

4accef2

- rollback flaky test local-only fix

12627b4

- old ver install fix too

04bf33d

- winOs workaround fix

b928d90

aidarkdev mentioned this pull request Mar 11, 2026

installation via cabal command from readme.md fails with error objectionary/phino#614

Closed

akasimov added 4 commits March 11, 2026 09:26

trigger ci

ea2dc2a

- s3 stored binaries linux&macOs test(win-bin waiting for now)

cc97fee

- add back win grunt run(with binary install)

413704b

trigger ci

63485f3

aidarkdev marked this pull request as ready for review March 12, 2026 16:24

maxonfjvipon suggested changes Mar 13, 2026

View reviewed changes

aidarkdev added 7 commits March 14, 2026 00:46

fix review issues

1e6aea2

- single export - single `phino` call on normalize command - cut code duplication on tests

- fix var naming

1d364f1

- only CI error debugging logs added.

814abc6

- only logs for flaky bug on CI

a331928

- more deep info for flaky problem

ab65ed0

- even one more extended logging for CI error debug

8bdc2c6

- skip fail-test to see logs of normalize when command not even failed

1f71290

aidarkdev mentioned this pull request Mar 14, 2026

pre-build binary(by `latest' link from readme) for ubuntu is outdated or even broken objectionary/phino#624

Closed

aidarkdev added 2 commits March 16, 2026 21:08

trigger CI

63907aa

- try to figth with cahed request

9670a29

aidarkdev added 5 commits March 16, 2026 21:47

- cut debug logs

c6a0b20

- back tests skipped before for debug - fix link to latest phino binary

trigger CI

2cdac43

- still fix phino bin links

40a89cb

trigger CI

2de4e2d

trigger CI

d51589e

maxonfjvipon suggested changes Mar 17, 2026

View reviewed changes

- vars naming fix

49c58cb

maxonfjvipon approved these changes Mar 17, 2026

View reviewed changes

aidarkdev mentioned this pull request Mar 21, 2026

on objectionary/eoc repo pre-merge build fails due not installed phino util yegor256/rultor#2285

Closed

- rultor merge phino install fix

09e21c0

yegor256 merged commit 061131c into objectionary:master Mar 22, 2026
17 checks passed

Conversation

aidarkdev commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aidarkdev commented Mar 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aidarkdev Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aidarkdev commented Mar 17, 2026

Uh oh!

maxonfjvipon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maxonfjvipon commented Mar 18, 2026

Uh oh!

aidarkdev commented Mar 19, 2026

Uh oh!

aidarkdev commented Mar 19, 2026

Uh oh!

aidarkdev commented Mar 20, 2026

Uh oh!

yegor256 commented Mar 20, 2026

Uh oh!

rultor commented Mar 21, 2026

Uh oh!

rultor commented Mar 21, 2026

Uh oh!

maxonfjvipon commented Mar 21, 2026

Uh oh!

aidarkdev commented Mar 21, 2026

Uh oh!

aidarkdev commented Mar 21, 2026

Uh oh!

Uh oh!

yegor256 commented Mar 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aidarkdev commented Mar 9, 2026 •

edited

Loading

aidarkdev Mar 13, 2026 •

edited

Loading